Commitda413d6

Andy

authored

Remove unnecessary filtering of tsx completions (microsoft#24004)

1 parent11e3e24 commitda413d6Copy full SHA for da413d6

File tree

+25

-8

lines changed

+25

-8

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -899,7 +899,7 @@ namespace FourSlash {`
`899`	`899`	`}`
`900`	`900`	`else{`
`901`	`901`	`constfound=actualByName.get(exclude.name);`
`902`		`-if(found.source===exclude.source){`
	`902`	`+if(found&&found.source===exclude.source){`
`903`	`903`	this.raiseError(`Did not expect to get a completion named${exclude.name} with source${exclude.source}`);
`904`	`904`	`}`
`905`	`905`	`}`

Lines changed: 3 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -972,12 +972,8 @@ namespace ts.Completions {`
`972`	`972`	`}`
`973`	`973`	`elseif(isRightOfOpenTag){`
`974`	`974`	`consttagSymbols=Debug.assertEachDefined(typeChecker.getJsxIntrinsicTagNamesAt(location),"getJsxIntrinsicTagNames() should all be defined");`
`975`		`-if(tryGetGlobalSymbols()){`
`976`		`-symbols=tagSymbols.concat(symbols.filter(s=>!!(s.flags&(SymbolFlags.Value\|SymbolFlags.Alias))));`
`977`		`-}`
`978`		`-else{`
`979`		`-symbols=tagSymbols;`
`980`		`-}`
	`975`	`+tryGetGlobalSymbols();`
	`976`	`+symbols=tagSymbols.concat(symbols);`
`981`	`977`	`completionKind=CompletionKind.MemberLike;`
`982`	`978`	`}`
`983`	`979`	`elseif(isStartingCloseTag){`
`@@ -1298,7 +1294,7 @@ namespace ts.Completions {`
`1298`	`1294`	`constexportedSymbols=typeChecker.getExportsOfModule(symbol);`
`1299`	`1295`	`// If the exported symbols contains type,`
`1300`	`1296`	`// symbol can be referenced at locations where type is allowed`
`1301`		`-returnforEach(exportedSymbols,symbolCanBeReferencedAtTypeLocation);`
	`1297`	`+returnexportedSymbols.some(symbolCanBeReferencedAtTypeLocation);`
`1302`	`1298`	`}`
`1303`	`1299`	`}`
`1304`	`1300`

Lines changed: 21 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,21 @@`
	`1`	`+/// <reference path="fourslash.ts" />`
	`2`	`+`
	`3`	`+//@noLib: true`
	`4`	`+//@nolib: true`
	`5`	`+//@jsx: preserve`
	`6`	`+`
	`7`	`+//@Filename: /a.tsx`
	`8`	`+////export type Bar = 0;`
	`9`	`+////export default function Foo() {};`
	`10`	`+`
	`11`	`+//@Filename: /b.tsx`
	`12`	`+////<Fo/**/ />;`
	`13`	`+`
	`14`	`+verify.completions({`
	`15`	`+marker:"",`
	`16`	`+includes:{name:"Foo",source:"/a.tsx",hasAction:true},`
	`17`	`+excludes:"Bar",`
	`18`	`+preferences:{`
	`19`	`+includeCompletionsForModuleExports:true,`
	`20`	`+},`
	`21`	`+});`

Comments

(0)