Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork25
feat(abg)!: replace data class perks by code generation in bindings#1644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:vampire/binding-version-v2
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Vampire commentedSep 6, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
fcb93fe
tof2e6c05
Compare6e0c383
to05942ab
Comparef2e6c05
tof9bff8a
Compare26ff564
to915be83
Compare5b756f4
toa485fe4
Compare915be83
to01e7a87
Comparea485fe4
to6c58c0d
Compare01e7a87
to781eb1b
Compare6c58c0d
to66b9afd
Compare781eb1b
to248813f
Compare66b9afd
tof8e466f
Compare248813f
toa5da3b1
Comparef8e466f
toeb02b5a
Comparea5da3b1
tof58ac6b
Compareeb02b5a
to36a0a91
Comparef58ac6b
tof11c738
Compare36a0a91
to8895541
Comparef11c738
to5e87ccb
Compare8895541
to4281b5d
Compare5e87ccb
toc89a7e1
CompareUh oh!
There was an error while loading.Please reload this page.
- The `equals` method will work like before. | ||
- The `hashCode` method will work like before. | ||
- The `toString` method will work like before. | ||
- Destructuring assignments are not possible anymore as this will likely break silently or during |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I initially wanted to ask why this change is made under v2 of the bindings server, and it's probably because of this remark about destructuring. I think it's enough to providecomponent1
...componentN
functions, then destructuring should work, and we wouldn't have to bump the route version just yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My plan is to revisit our discussion we had on Slack to ensure that there's no simpler option to achieve what we want. Sometimes ideas come after time 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's see if someone has some interesting take on this:https://kotlinlang.slack.com/archives/C8C4JTXR7/p1729233924861659
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it's enough to provide component1...componentN functions, then destructuring should work, and we wouldn't have to bump the route version just yet.
It would not be, as said on Slack.
It was intentional I left them out.
And additionally thecopy
method now also enforces named-arguments which is also a breaking change.
So to replicate here too, the goal here was not to somehow make it compatible with the upcoming Kotlin versions, but to improve the API to the originally intended way.
That this also fixes the copy visibility thing is merely a by-product and just was the trigger to finally have a look at it.
4281b5d
to1f9acc7
Comparec89a7e1
tofb71bbb
Compare5fdc48f
to4fa6848
Compare53c27b0
toc9e8a2f
Comparebce3f2f
to30806a5
Comparec9e8a2f
tod0ef59a
Compare30806a5
to2f28590
Compared0ef59a
to1e38b69
Compare2f28590
to90c380f
Compare1e38b69
to54a0d0e
Compare90c380f
to83e3806
Compare0af24c3
to16cb955
Compare4210942
tod3ecf79
Compare78db07b
to88a11f6
Compared3ecf79
tof72df5e
Compare88a11f6
to5b5bb0f
Comparef72df5e
to3591e61
Compare5b5bb0f
to2974c43
Compare3591e61
to8df1350
Compare2974c43
to481b627
Compare8df1350
todd21b0f
Compare481b627
tob4d13ce
Comparedd21b0f
to1542f03
Compareb4d13ce
toe788dc0
Compare1542f03
to98fc017
Compare
Fixes#1629