Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(abg)!: replace data class perks by code generation in bindings#1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Vampire wants to merge1 commit intovampire/binding-version-v2
base:vampire/binding-version-v2
Choose a base branch
Loading
fromvampire/no-data-bindings

Conversation

Vampire
Copy link
Collaborator

Fixes#1629

@VampireGraphite App
Copy link
CollaboratorAuthor

Vampire commentedSep 6, 2024
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
Learn more

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@VampireVampireforce-pushed thevampire/no-data-bindings branch 2 times, most recently fromfcb93fe tof2e6c05CompareSeptember 6, 2024 22:12
@VampireVampireforce-pushed thevampire/versioned-routes branch from6e0c383 to05942abCompareSeptember 8, 2024 08:10
@VampireVampireforce-pushed thevampire/no-data-bindings branch fromf2e6c05 tof9bff8aCompareSeptember 8, 2024 08:11
@VampireVampire changed the base branch fromvampire/versioned-routes tovampire/binding-version-v2September 8, 2024 08:11
@VampireVampireforce-pushed thevampire/no-data-bindings branch 2 times, most recently from26ff564 to915be83CompareSeptember 8, 2024 15:23
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from5b756f4 toa485fe4CompareSeptember 8, 2024 20:27
@VampireVampireforce-pushed thevampire/no-data-bindings branch from915be83 to01e7a87CompareSeptember 8, 2024 20:27
@VampireVampireforce-pushed thevampire/binding-version-v2 branch froma485fe4 to6c58c0dCompareSeptember 9, 2024 08:05
@VampireVampireforce-pushed thevampire/no-data-bindings branch from01e7a87 to781eb1bCompareSeptember 9, 2024 08:05
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from6c58c0d to66b9afdCompareSeptember 9, 2024 10:57
@VampireVampireforce-pushed thevampire/no-data-bindings branch from781eb1b to248813fCompareSeptember 9, 2024 10:57
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from66b9afd tof8e466fCompareSeptember 10, 2024 16:43
@VampireVampireforce-pushed thevampire/no-data-bindings branch from248813f toa5da3b1CompareSeptember 10, 2024 16:43
@VampireVampireforce-pushed thevampire/binding-version-v2 branch fromf8e466f toeb02b5aCompareSeptember 23, 2024 08:13
@VampireVampireforce-pushed thevampire/no-data-bindings branch froma5da3b1 tof58ac6bCompareSeptember 23, 2024 08:13
@VampireVampireforce-pushed thevampire/binding-version-v2 branch fromeb02b5a to36a0a91CompareSeptember 24, 2024 00:41
@VampireVampireforce-pushed thevampire/no-data-bindings branch fromf58ac6b tof11c738CompareSeptember 24, 2024 00:41
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from36a0a91 to8895541CompareSeptember 29, 2024 17:29
@VampireVampireforce-pushed thevampire/no-data-bindings branch fromf11c738 to5e87ccbCompareSeptember 29, 2024 17:29
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from8895541 to4281b5dCompareSeptember 29, 2024 21:12
@VampireVampireforce-pushed thevampire/no-data-bindings branch from5e87ccb toc89a7e1CompareSeptember 29, 2024 21:12
- The `equals` method will work like before.
- The `hashCode` method will work like before.
- The `toString` method will work like before.
- Destructuring assignments are not possible anymore as this will likely break silently or during
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I initially wanted to ask why this change is made under v2 of the bindings server, and it's probably because of this remark about destructuring. I think it's enough to providecomponent1...componentN functions, then destructuring should work, and we wouldn't have to bump the route version just yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

My plan is to revisit our discussion we had on Slack to ensure that there's no simpler option to achieve what we want. Sometimes ideas come after time 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's see if someone has some interesting take on this:https://kotlinlang.slack.com/archives/C8C4JTXR7/p1729233924861659

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it's enough to provide component1...componentN functions, then destructuring should work, and we wouldn't have to bump the route version just yet.

It would not be, as said on Slack.
It was intentional I left them out.
And additionally thecopy method now also enforces named-arguments which is also a breaking change.
So to replicate here too, the goal here was not to somehow make it compatible with the upcoming Kotlin versions, but to improve the API to the originally intended way.
That this also fixes the copy visibility thing is merely a by-product and just was the trigger to finally have a look at it.

@VampireVampireforce-pushed thevampire/binding-version-v2 branch from4281b5d to1f9acc7CompareOctober 27, 2024 03:52
@VampireVampireforce-pushed thevampire/no-data-bindings branch fromc89a7e1 tofb71bbbCompareOctober 27, 2024 03:52
@VampireVampireforce-pushed thevampire/no-data-bindings branch 2 times, most recently from5fdc48f to4fa6848CompareApril 30, 2025 18:08
@VampireVampireforce-pushed thevampire/binding-version-v2 branch 2 times, most recently from53c27b0 toc9e8a2fCompareMay 1, 2025 22:25
@VampireVampireforce-pushed thevampire/no-data-bindings branch 2 times, most recently frombce3f2f to30806a5CompareMay 1, 2025 23:56
@VampireVampireforce-pushed thevampire/binding-version-v2 branch fromc9e8a2f tod0ef59aCompareMay 1, 2025 23:56
@VampireVampireforce-pushed thevampire/no-data-bindings branch from30806a5 to2f28590CompareMay 2, 2025 11:16
@VampireVampireforce-pushed thevampire/binding-version-v2 branch fromd0ef59a to1e38b69CompareMay 2, 2025 11:16
@VampireVampireforce-pushed thevampire/no-data-bindings branch from2f28590 to90c380fCompareMay 2, 2025 11:51
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from1e38b69 to54a0d0eCompareMay 2, 2025 11:52
@VampireVampireforce-pushed thevampire/no-data-bindings branch from90c380f to83e3806CompareMay 2, 2025 12:34
@VampireVampireforce-pushed thevampire/binding-version-v2 branch 2 times, most recently from0af24c3 to16cb955CompareMay 4, 2025 18:39
@VampireVampireforce-pushed thevampire/no-data-bindings branch 2 times, most recently from4210942 tod3ecf79CompareMay 6, 2025 13:09
@VampireVampireforce-pushed thevampire/binding-version-v2 branch 2 times, most recently from78db07b to88a11f6CompareMay 12, 2025 12:32
@VampireVampireforce-pushed thevampire/no-data-bindings branch fromd3ecf79 tof72df5eCompareMay 12, 2025 12:32
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from88a11f6 to5b5bb0fCompareMay 12, 2025 12:39
@VampireVampireforce-pushed thevampire/no-data-bindings branch fromf72df5e to3591e61CompareMay 12, 2025 12:39
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from5b5bb0f to2974c43CompareMay 12, 2025 15:26
@VampireVampireforce-pushed thevampire/no-data-bindings branch from3591e61 to8df1350CompareMay 12, 2025 15:26
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from2974c43 to481b627CompareMay 14, 2025 13:23
@VampireVampireforce-pushed thevampire/no-data-bindings branch from8df1350 todd21b0fCompareMay 14, 2025 13:23
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from481b627 tob4d13ceCompareMay 20, 2025 09:49
@VampireVampireforce-pushed thevampire/no-data-bindings branch fromdd21b0f to1542f03CompareMay 20, 2025 09:49
@VampireVampireforce-pushed thevampire/binding-version-v2 branch fromb4d13ce toe788dc0CompareMay 20, 2025 10:08
@VampireVampireforce-pushed thevampire/no-data-bindings branch from1542f03 to98fc017CompareMay 20, 2025 10:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@krzema12krzema12Awaiting requested review from krzema12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Vampire@krzema12

[8]ページ先頭

©2009-2025 Movatter.jp