Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(abg): support different binding versions on different server routes#1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Vampire wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromvampire/versioned-routes

Conversation

Vampire
Copy link
Collaborator

No description provided.

@VampireGraphite App
Copy link
CollaboratorAuthor

Vampire commentedSep 5, 2024
edited
Loading

@VampireVampireforce-pushed thevampire/versioned-routes branch from029b490 to7972d27CompareSeptember 5, 2024 11:09
@VampireGraphite App
Copy link
CollaboratorAuthor

Here a sketch how versioned routes could work, or if you like it maybe even the ready implementation. :-)

If a version is marked as deprecated, the binding classes are deprecated with a deprecation message that the binding version is deprecated. It also prints out a warning if you run it manually and additionally when run on GitHub Actions emits a GitHub Actions warning, as most often you will not see this locally due to Maven Local cached binding jar.

I would as far as possible not remove deprecated binding versions, just hint users with it to upgrade to a newer binding version.

New binding versions are by default marked experimental and issue similar warnings, with the last stable binding version in the message.

TheBindingVersion can then be propagated down to the generation code where needed to generate things depending on the requested binding version.

TheBindingVersion also has a property which library version should be used as dependency version that is compatible with the generated binding version, so that for example a v1 binding does not depend on a library version having a modifiedStep signature, or that a v2 binding does not depend on a library version that does not yet have theExpression class available.

Theoretically, we could also in the generated classesinit block add a version check for compatibility, but I guess most often you will hit a compilation error before already so it will not be reached.

Then when a new binding version is added, we can add a page to the docs that documents which library version is compatible with which binding version, and which breaking changes happened from one binding version to the next, besides requiring a new library version eventually.

@VampireVampireforce-pushed thevampire/versioned-routes branch from7972d27 tof39757dCompareSeptember 5, 2024 18:49
@VampireVampire changed the titlefeat(abg): Support different binding versions on different server routesfeat(abg): support different binding versions on different server routesSep 5, 2024
@VampireVampireforce-pushed thevampire/versioned-routes branch 2 times, most recently from6aef8d4 to6e0c383CompareSeptember 6, 2024 18:41
@VampireVampire changed the base branch frommain tovampire/use-buildCodeBlockSeptember 6, 2024 18:43
@VampireVampireforce-pushed thevampire/versioned-routes branch from6e0c383 to05942abCompareSeptember 8, 2024 08:10
@VampireVampire changed the base branch fromvampire/use-buildCodeBlock tomainSeptember 8, 2024 08:10
@VampireVampireforce-pushed thevampire/versioned-routes branch 4 times, most recently from8edd315 to00a3375CompareSeptember 10, 2024 16:43
@VampireVampireforce-pushed thevampire/versioned-routes branch 4 times, most recently from2c8968b toe7c3171CompareSeptember 29, 2024 21:12
@VampireVampireforce-pushed thevampire/versioned-routes branch 8 times, most recently from449f7e8 toebabafeCompareOctober 30, 2024 14:13
@VampireVampireforce-pushed thevampire/versioned-routes branch 7 times, most recently fromd3d2ee6 toe19bae0CompareFebruary 26, 2025 10:21
@VampireVampireforce-pushed thevampire/versioned-routes branch frome19bae0 to8222000CompareMarch 14, 2025 14:59
@VampireVampireforce-pushed thevampire/versioned-routes branch from8222000 tof1e42c2CompareApril 1, 2025 11:02
@VampireVampireforce-pushed thevampire/versioned-routes branch 5 times, most recently from6965e42 to198ea53CompareApril 18, 2025 14:44
@VampireVampireforce-pushed thevampire/versioned-routes branch 9 times, most recently froma58151e toa35c588CompareMay 6, 2025 13:09
@VampireVampireforce-pushed thevampire/versioned-routes branch 4 times, most recently from1832b54 to86db4c4CompareMay 14, 2025 13:23
@VampireVampireforce-pushed thevampire/versioned-routes branch from86db4c4 tod518c2bCompareMay 20, 2025 09:49
@VampireVampireforce-pushed thevampire/versioned-routes branch fromd518c2b to671733fCompareMay 20, 2025 10:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@Vampire

[8]ページ先頭

©2009-2025 Movatter.jp