Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork25
feat(abg)!: allow to wire typed outputs to matching typed inputs#1624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:vampire/binding-version-v2
Are you sure you want to change the base?
feat(abg)!: allow to wire typed outputs to matching typed inputs#1624
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Vampire commentedAug 23, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
ff26830
to46ca5ad
CompareVampire commentedAug 23, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
So far it indeed seems to work just great. |
Main remaining problem is probably the naming athttps://github.com/typesafegithub/github-workflows-kt/pull/1624/files#diff-76c4a08acf57b6c491c34cc60e6ad7bbc219fbd45dc0dda74550941ecac51200 :-/ |
46ca5ad
to14d4f80
CompareOf course the typing catalog should be polished to have proper output types which it currently does not have. |
14d4f80
tof4b6351
Compare3a53468
tof0429b9
CompareForgot the job outputs, now they are also typed :-) |
adbea5b
to59626c0
CompareAnd now |
90360a0
to09d160e
Compared7c1b5d
tof3b7790
Compare60da5e6
to53c27b0
Compare1c80ac5
tocdeb8d0
Compare53c27b0
toc9e8a2f
Comparecdeb8d0
toda90471
Comparec9e8a2f
tod0ef59a
Compareda90471
to0937347
Compared0ef59a
to1e38b69
Compare0937347
to8eabe36
Compare1e38b69
to54a0d0e
Compare8eabe36
to3cb4b89
Compare54a0d0e
to0af24c3
Compare3cb4b89
to3fc563c
Compare0af24c3
to16cb955
Compare3fc563c
to0dd5cd3
Compare78db07b
to88a11f6
Compare454f1fb
toe1487be
Compare5b5bb0f
to2974c43
Comparee1487be
tod077e1e
Compare2974c43
to481b627
Compared077e1e
to3cf8517
Compare481b627
tob4d13ce
Compare3cf8517
toa32478e
Compareb4d13ce
toe788dc0
Comparea32478e
to1239cdc
Compare
Uh oh!
There was an error while loading.Please reload this page.
Fixes#73
If types of input and output match, you can do
lookupOnlyExpression= cache.outputs.cacheHit
If types do not match for whatever reason, you can still do
lookupOnlyExpression= cache.outputs.cacheHit_Untyped
or
or (but deprecated)
lookupOnly_Untyped= cache.outputs.cacheHit.expressionString
If no type is declared for the output, you can still stuff the
_Untyped
one into any expression input likelookupOnlyExpression= cache.outputs.cacheHit_Untyped
Ad-hoc outputs behave like untyped outputs in that you can stuff it into everywhere