Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(abg)!: allow to wire typed outputs to matching typed inputs#1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Vampire wants to merge1 commit intovampire/binding-version-v2
base:vampire/binding-version-v2
Choose a base branch
Loading
fromvampire/type-safe-inputs-and-outputs-wiring

Conversation

Vampire
Copy link
Collaborator

@VampireVampire commentedAug 23, 2024
edited
Loading

Fixes#73

If types of input and output match, you can do

lookupOnlyExpression= cache.outputs.cacheHit

If types do not match for whatever reason, you can still do

lookupOnlyExpression= cache.outputs.cacheHit_Untyped

or

lookupOnlyExpression=Expression(cache.outputs.cacheHit.expression)

or (but deprecated)

lookupOnly_Untyped= cache.outputs.cacheHit.expressionString

If no type is declared for the output, you can still stuff the_Untyped one into any expression input like

lookupOnlyExpression= cache.outputs.cacheHit_Untyped

Ad-hoc outputs behave like untyped outputs in that you can stuff it into everywhere

lookupOnlyExpression= cache.outputs["cache-hit"]

@VampireGraphite App
Copy link
CollaboratorAuthor

Vampire commentedAug 23, 2024
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
Learn more

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch 3 times, most recently fromff26830 to46ca5adCompareAugust 23, 2024 20:34
@Vampire
Copy link
CollaboratorAuthor

Vampire commentedAug 23, 2024
edited
Loading

So far it indeed seems to work just great.
I played a bit with the current state, merged with my other stack.

@Vampire
Copy link
CollaboratorAuthor

@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch from46ca5ad to14d4f80CompareAugust 23, 2024 20:44
@Vampire
Copy link
CollaboratorAuthor

Of course the typing catalog should be polished to have proper output types which it currently does not have.
That's anyway a bit bad, as the typing catalog is supposed to be independent of consumers, so just usingstring everywhere just because this lib does not yet read it, ..., well, ... ;-)

@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch from14d4f80 tof4b6351CompareAugust 23, 2024 21:13
@VampireVampire marked this pull request as ready for reviewAugust 23, 2024 21:23
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch 2 times, most recently from3a53468 tof0429b9CompareAugust 25, 2024 02:19
@VampireGraphite App
Copy link
CollaboratorAuthor

Forgot the job outputs, now they are also typed :-)

@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch 9 times, most recently fromadbea5b to59626c0CompareAugust 31, 2024 18:28
@VampireGraphite App
Copy link
CollaboratorAuthor

And nowAbstractResult also has atoExpression() function :-)

@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch 4 times, most recently from90360a0 to09d160eCompareSeptember 5, 2024 18:48
@VampireVampire changed the titlefeat(abg)!: Allow to wire typed outputs to matching typed inputsfeat(abg)!: allow to wire typed outputs to matching typed inputsSep 5, 2024
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch 2 times, most recently fromd7c1b5d tof3b7790CompareSeptember 6, 2024 18:43
@VampireVampireforce-pushed thevampire/binding-version-v2 branch 2 times, most recently from60da5e6 to53c27b0CompareApril 30, 2025 18:08
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch 2 times, most recently from1c80ac5 tocdeb8d0CompareMay 1, 2025 22:25
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from53c27b0 toc9e8a2fCompareMay 1, 2025 22:25
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch fromcdeb8d0 toda90471CompareMay 1, 2025 23:56
@VampireVampireforce-pushed thevampire/binding-version-v2 branch fromc9e8a2f tod0ef59aCompareMay 1, 2025 23:56
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch fromda90471 to0937347CompareMay 2, 2025 11:16
@VampireVampireforce-pushed thevampire/binding-version-v2 branch fromd0ef59a to1e38b69CompareMay 2, 2025 11:16
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch from0937347 to8eabe36CompareMay 2, 2025 11:51
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from1e38b69 to54a0d0eCompareMay 2, 2025 11:51
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch from8eabe36 to3cb4b89CompareMay 2, 2025 12:34
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from54a0d0e to0af24c3CompareMay 2, 2025 12:34
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch from3cb4b89 to3fc563cCompareMay 4, 2025 18:39
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from0af24c3 to16cb955CompareMay 4, 2025 18:39
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch from3fc563c to0dd5cd3CompareMay 6, 2025 13:09
@VampireVampireforce-pushed thevampire/binding-version-v2 branch 2 times, most recently from78db07b to88a11f6CompareMay 12, 2025 12:32
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch 2 times, most recently from454f1fb toe1487beCompareMay 12, 2025 12:39
@VampireVampireforce-pushed thevampire/binding-version-v2 branch 2 times, most recently from5b5bb0f to2974c43CompareMay 12, 2025 15:26
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch frome1487be tod077e1eCompareMay 12, 2025 15:26
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from2974c43 to481b627CompareMay 14, 2025 13:23
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch fromd077e1e to3cf8517CompareMay 14, 2025 13:23
@VampireVampireforce-pushed thevampire/binding-version-v2 branch from481b627 tob4d13ceCompareMay 20, 2025 09:49
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch from3cf8517 toa32478eCompareMay 20, 2025 09:49
@VampireVampireforce-pushed thevampire/binding-version-v2 branch fromb4d13ce toe788dc0CompareMay 20, 2025 10:08
@VampireVampireforce-pushed thevampire/type-safe-inputs-and-outputs-wiring branch froma32478e to1239cdcCompareMay 20, 2025 10:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core feature request] Allow passing non-string outputs to inputs
1 participant
@Vampire

[8]ページ先頭

©2009-2025 Movatter.jp