- Notifications
You must be signed in to change notification settings - Fork773
test: added test for Video Room, fix: resolved conflict of duplicated names, enhanced code of 'time' logic#845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
dlunaaa wants to merge5 commits intotwilio:mainChoose a base branch fromdlunaaa:main
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…aming conflict, and add Twilio Video Room test- Improved JWT expiration logic: - Replaced time.time() with datetime.datetime.utcnow() to ensure more accurate expiration handling. - Applied datetime.timedelta(seconds=...) for better timestamp calculations. - Ensured compatibility with jwt.encode() by converting expiration times using .timestamp().- Resolved naming issue between ALGORITHM and algorithm: - Renamed the algorithm parameter to jwt_algorithm to avoid conflicts with the ALGORITHM constant. - Updated all references to maintain consistency throughout the class.- Added unit test for Twilio Video Room creation: - Integrated unittest framework for structured testing. - Used responses library to mock Twilio API calls. - Implemented a test case that validates room creation by checking sid, unique_name, and status.These updates improve JWT handling, fix potential naming conflicts, and introduce automated testing for Twilio API interactions.
Hi@dlunaaa! Thanks for raising this PR. The files inside rest folder are autogenerated. To add tests for that, please use cluster test. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
feat(jwt): Improve JWT expiration handling and fix naming conflicts
time.time()
withdatetime.datetime.utcnow()
to ensure accurate expiration handling.datetime.timedelta(seconds=...)
for better timestamp calculations.jwt.encode()
by converting expiration times using.timestamp()
.algorithm
tojwt_algorithm
to avoid conflicts with theALGORITHM
constant and ensure consistency.test(twilio): Add unit test for Twilio Video Room creation
unittest
framework for structured testing.responses
library to mock Twilio API calls.sid
,unique_name
, andstatus
.These changes enhance JWT handling, resolve potential naming conflicts, and introduce automated testing for Twilio API interactions.
Fixes#777
Summary of Changes
This PR addresses the following improvements:
Fix for IssueCode Enhancement #777 (JWT Expiration Handling):
time.time()
withdatetime.datetime.utcnow()
to ensure accurate expiration calculations.datetime.timedelta(seconds=...)
to improve timestamp consistency.jwt.encode()
by converting expiration times using.timestamp()
.Resolved SonarCloud issue (Naming Conflict with ALGORITHM):
algorithm
parameter tojwt_algorithm
to prevent confusion with theALGORITHM
constant.Added a new unit test for Twilio Video Room creation:
unittest
framework for structured testing.responses
library.sid
,unique_name
, andstatus
.Checklist
.md
file (not required).If you have questions, please file asupport ticket, or create a GitHub Issue in this repository.