- Notifications
You must be signed in to change notification settings - Fork772
chore: prefer unittest.mock from the standard library for Python >=3.8#793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
a-detiste wants to merge1 commit intotwilio:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
tiwarishubham635 commentedMay 24, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I see your changes. So that means if we want to support python 3.7, then mock can't be used directly? In a sense, we'll still have the dependency on unittest. Is that right? |
Hi.It s a partial dependency.Distrubtions that don't support py3.7 can drop mock.There s a special syntax for setup.py/requirements.txt to says thisdependency only applies for Python version X, I don't use it actively but Ican find examples in other projectsLe ven. 24 mai 2024, 09:10, Shubham ***@***.***> a écrit : … I see your changes. So that means if we want to support python 3.7, then mock can't be used directly? In a sense, we'll still have a dependency. Is that right? — Reply to this email directly, view it on GitHub <#793 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB47WUFKU3EGCCWI7A3PAGTZD3RYDAVCNFSM6AAAAABIGMCJP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRYG42TENBUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***> |
@tiwarishubham635 unittest is part of the standard library |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps compatibility with Python3.7