- Notifications
You must be signed in to change notification settings - Fork800
Remove shipped certs#376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dougblack left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tests?
pshafton commentedJul 14, 2017
Don't we still need to provide the path to the CA Bundle even if we use the certifi package. We would need the get_cert_file logic to change to... import certifi |
jingming commentedJul 14, 2017
From my understanding ofhttps://github.com/requests/requests/blob/master/requests/adapters.py#L221 andhttps://github.com/requests/requests/blob/master/requests/utils.py#L39, I think requests will do this automatically. |
pshafton commentedJul 14, 2017
Ok. It would be good to verify that behavior. Not sure why our simple test was giving us a warning then. |
jmctwilio commentedAug 7, 2017
@jingming If you can resolve the conflicts, I think we can mark this as [deploy], yes? |
jingming commentedAug 7, 2017
@jmctwilio conflicts resolved. |
Commitd75a66b (twilio#376) should haveremoved this.Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Commitd75a66b (twilio#376) should haveremoved this.Signed-off-by: Anders Kaseorg <andersk@mit.edu>
No description provided.