Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: Preview for removing encoding from Phone NUmber format#871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
manisha1997 wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromdouble-encoding

Conversation

manisha1997
Copy link
Contributor

@manisha1997manisha1997 commentedJul 1, 2025
edited by tiwarishubham635
Loading

Fixes#793

Preview fortwilio/twilio-oai-generator#657

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read theContribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file asupport ticket, or create a GitHub Issue in this repository.

@sonarqubecloudSonarQubeCloud
Copy link

Copy link
Contributor

@tiwarishubham635tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Verified affected APIs by making calls

manisha1997 added a commit to twilio/twilio-oai-generator that referenced this pull requestJul 2, 2025
…mat (#657)<!--We appreciate the effort for this pull request but before that pleasemake sure you read the contribution guidelines, then fill out the blanksbelow.Please format the PR title appropriately based on the type of change:  <type>[!]: <description>Where <type> is one of: docs, chore, feat, fix, test, misc.Add a '!' after the type for breaking changes (e.g. feat!: new breakingfeature).**All third-party contributors acknowledge that any contributions theyprovide will be made under the same open-source license that theopen-source project is provided under.**Please enter each Issue number you are resolving in your PR after one ofthe following words [Fixes, Closes, Resolves]. This will auto-link theseissues and close them when this PR is merged!e.g.Fixes#1Closes#2--># Fixes #This PR removes encoding in case of phone number format because all pathparams are anyway encodedhttps://github.com/twilio/twilio-java/blob/4f46e707d6931c50888c26b2dbd3c4452ea076e1/src/main/java/com/twilio/http/Request.java#L213Preview PR:twilio/twilio-java#871### Checklist- [x] I acknowledge that all my contributions will be made under theproject's license- [ ] Run `make test-docker`- [ ] Verify affected language:- [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our[OpenAPI specification](https://github.com/twilio/twilio-oai) using the[build_twilio_go.py](./examples/build_twilio_go.py) using `pythonexamples/build_twilio_go.py path/to/twilio-oai/spec/yamlpath/to/twilio-go` and inspect the diff    - [ ] Run `make test` in `twilio-go`    - [ ] Create a pull request in `twilio-go`    - [ ] Provide a link below to the pull request- [ ] I have made a material change to the repo (functionality, testing,spelling, grammar)- [ ] I have read the [ContributionGuidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md)and my PR follows them- [ ] I have titled the PR appropriately- [ ] I have updated my branch with the main branch- [ ] I have added tests that prove my fix is effective or that myfeature works- [ ] I have added the necessary documentation about the functionalityin the appropriate .md file- [ ] I have added inline documentation to the code I modifiedIf you have questions, please create a GitHub Issue in this repository.Co-authored-by: twilio-dx <team_interfaces+github@twilio.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tiwarishubham635tiwarishubham635tiwarishubham635 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NumberFetcher is double encoding the number
3 participants
@manisha1997@tiwarishubham635@twilio-dx

[8]ページ先頭

©2009-2025 Movatter.jp