- Notifications
You must be signed in to change notification settings - Fork445
chore: Preview for removing encoding from Phone NUmber format#871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
manisha1997 wants to merge2 commits intomainChoose a base branch fromdouble-encoding
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
14 tasks
tiwarishubham635 approved these changesJul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! Verified affected APIs by making calls
manisha1997 added a commit to twilio/twilio-oai-generator that referenced this pull requestJul 2, 2025
…mat (#657)<!--We appreciate the effort for this pull request but before that pleasemake sure you read the contribution guidelines, then fill out the blanksbelow.Please format the PR title appropriately based on the type of change: <type>[!]: <description>Where <type> is one of: docs, chore, feat, fix, test, misc.Add a '!' after the type for breaking changes (e.g. feat!: new breakingfeature).**All third-party contributors acknowledge that any contributions theyprovide will be made under the same open-source license that theopen-source project is provided under.**Please enter each Issue number you are resolving in your PR after one ofthe following words [Fixes, Closes, Resolves]. This will auto-link theseissues and close them when this PR is merged!e.g.Fixes#1Closes#2--># Fixes #This PR removes encoding in case of phone number format because all pathparams are anyway encodedhttps://github.com/twilio/twilio-java/blob/4f46e707d6931c50888c26b2dbd3c4452ea076e1/src/main/java/com/twilio/http/Request.java#L213Preview PR:twilio/twilio-java#871### Checklist- [x] I acknowledge that all my contributions will be made under theproject's license- [ ] Run `make test-docker`- [ ] Verify affected language:- [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our[OpenAPI specification](https://github.com/twilio/twilio-oai) using the[build_twilio_go.py](./examples/build_twilio_go.py) using `pythonexamples/build_twilio_go.py path/to/twilio-oai/spec/yamlpath/to/twilio-go` and inspect the diff - [ ] Run `make test` in `twilio-go` - [ ] Create a pull request in `twilio-go` - [ ] Provide a link below to the pull request- [ ] I have made a material change to the repo (functionality, testing,spelling, grammar)- [ ] I have read the [ContributionGuidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md)and my PR follows them- [ ] I have titled the PR appropriately- [ ] I have updated my branch with the main branch- [ ] I have added tests that prove my fix is effective or that myfeature works- [ ] I have added the necessary documentation about the functionalityin the appropriate .md file- [ ] I have added inline documentation to the code I modifiedIf you have questions, please create a GitHub Issue in this repository.Co-authored-by: twilio-dx <team_interfaces+github@twilio.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#793
Preview fortwilio/twilio-oai-generator#657
Checklist
If you have questions, please file asupport ticket, or create a GitHub Issue in this repository.