Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: added support for fetching access token from oauth server#786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
sbansla wants to merge3 commits intomain
base:main
Choose a base branch
Loading
fromoauth-client-and-test

Conversation

sbansla
Copy link
Contributor

@sbanslasbansla commentedMar 26, 2024•
edited
Loading

Fixes

Added support for fetching access token from OAuth server by passing clientId and clientSecret.
Pending: update readme

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read theContribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file asupport ticket, or create a GitHub Issue in this repository.

@sbanslasbansla changed the titleOauth client and testfeat: added support for fetching access token from oauth serverMar 26, 2024
@sonarqubecloudSonarQubeCloud
Copy link

Quality Gate FailedQuality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
8.4% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extensionSonarLint

@JsonProperty("audience")
@Getter
@Setter
private String audience = "https://www.twilio.com/organizations";
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For testing purpose this has been fixed, We need to fetch audience and grantType from open api specs.

@sbanslasbansla marked this pull request as draftMay 21, 2024 06:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kridaikridaiAwaiting requested review from kridai

@tiwarishubham635tiwarishubham635Awaiting requested review from tiwarishubham635

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@sbansla
[8]ページ先頭
©2009-2025 Movatter.jp