Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use cachednoop function#33496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
XhmikosR merged 5 commits intomainfromrohit/noop-handling
Apr 11, 2021
Merged

Use cachednoop function#33496

XhmikosR merged 5 commits intomainfromrohit/noop-handling
Apr 11, 2021

Conversation

rohit2sharma95
Copy link
Contributor

noop function returns a new function every time whenever it is called. So just use thenoop function, not the value returned by it (So that the event handler can remove the same function that was attached before).

Ref:#33451 (comment)

@XhmikosR
Copy link
Member

I recall noticing this in the past but forgot to make a separate PR for sure. :) That being said, shouldn't our tests have caught this? I meannull !==noop(). The extra args are OK, though.

@XhmikosRXhmikosR requested a review fromGeoSotMarch 30, 2021 12:50
@GeoSot
Copy link
Member

@XhmikosR I suppose, you rememberthis
Do we still need this tweak@patrickhlauke ?

@XhmikosR
Copy link
Member

Yeah, that's another change :) But I still wonder why this wasn't caught :/

@rohit2sharma95
Copy link
ContributorAuthor

Do we still need this tweak@patrickhlauke?

Not sure about that but that should be considered in another PR IMO (If that is not needed)@GeoSot. 🙂
So this PR is complete and will help#33466 to proceed.

@XhmikosRXhmikosR merged commitbac0b0c intomainApr 11, 2021
@XhmikosRXhmikosR deleted the rohit/noop-handling branchApril 11, 2021 06:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@patrickhlaukepatrickhlaukepatrickhlauke approved these changes

@GeoSotGeoSotGeoSot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rohit2sharma95@XhmikosR@GeoSot@patrickhlauke
[8]ページ先頭
©2009-2025 Movatter.jp