Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork79.2k
v5: drop Internet Explorer support#30377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e557531
to61f3599
Compare@Johann-S I think we could probably remove the |
fb2a541
to336798b
Compare This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading.Please reload this page.
before that we should maybe upgrade our browserlist to Edge >= 16, what do you think@XhmikosR ? |
so I'm definitely in favor of removing |
I split the The PR needs another review for the doc changes, a final rebase/squash of some of the patches and then we can merge it. |
3f94cb7
toe411ac8
CompareUh oh!
There was an error while loading.Please reload this page.
####Escape SVG | ||
We use the`escape-svg` function to escape the`<`,`>` and`#` characters for SVG background images. These characters need to be escaped to properly render the background images in IE. | ||
We use the`escape-svg` function to escape the`<`,`>` and`#` characters for SVG background images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This reminds me, maybe we should revisit the escape SVG function later.
rbonomo commentedApr 7, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Supporting IE would be a wise and thoughtful decision. You'll end up with people using a fork that supports IE. Supporting IE is a small challenge to overcome. There is an ongoing Hacker News discussion that links here for everyone's context:https://news.ycombinator.com/item?id=22802003 Today's reality is that there are IE users, and by not supporting them you are excluding them. |
mohe2015 commentedApr 7, 2020
I think they want to keep supporting bootstrap 4. |
mirap commentedApr 7, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Supporting Macromedia Flash would be a wise and thoughtful decision. Supporting Macromedia Flash is a small challenge to overcome. Today's reality is that there are Macromedia Flash users, and by not supporting them you are excluding them. #vogonpoetry |
withinboredom commentedApr 8, 2020
I think it’s more useful to point out which demographic would be using internet explorer instead of just saying “some users use it.” Such as military, government, schools, corporations, etc. These demographics are not reflected well in caniuse due to the fact that they’re already excluded from most of the popular web. However, these demographics are the most likely to use a framework such as this one, albeit, internally. You may be shooting yourself in the foot here. |
LegoStormtroopr commentedApr 8, 2020
To everyone saying, if you want to keep supporting IE just use Bootstrap4,Bootstrap4 is End-Of-Life at the end of this year: The decision to drop IE support is understandable, but as@withinboredom pointed out a lot of the education, government and big banking sectors still use IE (and do so with Microsofts blessing). Remove IE support from Bootstrap5, but at least give ussome longer support for Bootstrap4. |
keithn commentedApr 8, 2020
I think if you remove it, bootstrap no longer becomes a simple choice. BS5 suddenly turns into a bet, where BS4 is a safer bet, but it will become unmaintained. In my experience, the majority of IE11 users are often the users with $s who want to pay for products. Mostly because they are bigger companies/organizations. tough choice. |
This is the same issue as moving from v3 to v4 when we dropped support for IE9, and the same as moving from v2 to v3 when we dropped IE8. You can still use the older versions despite new ones coming out. |
Just to give some context. We went back and forth with this issue for quite some time. I, myself, was in favor of keeping IE support until it became an issue for us. In our last team call, we evaluated the pros and cons of keeping IE support and the pros outweigh the cons.
Now, in an ideal world we could have all of the above. But our world is not ideal. |
Uh oh!
There was an error while loading.Please reload this page.
Preview:https://deploy-preview-30377--twbs-bootstrap.netlify.com/