Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

v5: drop Internet Explorer support#30377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
XhmikosR merged 11 commits intomasterfrommaster-xmr-rm-ie
Mar 18, 2020
Merged

v5: drop Internet Explorer support#30377

XhmikosR merged 11 commits intomasterfrommaster-xmr-rm-ie
Mar 18, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosRXhmikosR commentedMar 11, 2020
edited
Loading

mohe2015, shimbaco, DrJume, florianlacreuse, SuperSandro2000, winzig, trevorgehman, etanec, mmdevcodes, kamui545, and 176 more reacted with thumbs up emojicglong and LegoStormtroopr reacted with thumbs down emojiConkley, yhoiseth, eliofreitas, gabriela-sartori, himynameisdave, matte, manavid, kiedtl, analystbruh, lampewebdev, and 13 more reacted with laugh emojimohe2015, mrtnvh, Leland, DrJume, FezVrasta, cweagans, lukbukkit, SuperSandro2000, winzig, trevorgehman, and 104 more reacted with hooray emojihstarikov-coursera, rbonomo, and cglong reacted with confused emojimohe2015, midzer, FezVrasta, SuperSandro2000, winzig, nwalters512, mdo, kamui545, YugasVasyl, Skaronator, and 60 more reacted with heart emojimohe2015, nteetor, MartijnCuppens, SuperSandro2000, winzig, kamui545, YugasVasyl, Skaronator, ThomOrlo, ffoodd, and 34 more reacted with rocket emojiemyarod, wouterkroes, jarjan, yordis, Conkley, gabriela-sartori, kiedtl, gtsiolis, and rbonomo reacted with eyes emoji
@XhmikosR
Copy link
MemberAuthor

@Johann-S I think we could probably remove themakeArray function too?https://caniuse.com/#feat=mdn-api_nodelist_foreach

zenopopovici and DrewDennison reacted with thumbs up emoji

@ysdsysdsforce-pushed themaster-xmr-rm-ie branch 2 times, most recently fromfb2a541 to336798bCompareMarch 11, 2020 15:16
@abarreraaponte

This comment has been minimized.

@richlira

This comment has been minimized.

@Johann-S
Copy link
Member

before that we should maybe upgrade our browserlist to Edge >= 16, what do you think@XhmikosR ?

@XhmikosR
Copy link
MemberAuthor

@Johann-S that's already done in#30378

@Johann-S
Copy link
Member

so I'm definitely in favor of removingmakeArray 👍

@XhmikosR
Copy link
MemberAuthor

I split themakeArray removal patch to another branch because it potentially affects more browsers than IE.

The PR needs another review for the doc changes, a final rebase/squash of some of the patches and then we can merge it.

ffoodd and DrewDennison reacted with hooray emoji

@XhmikosRXhmikosR changed the titlev5: remove IE supportv5: drop Internet Explorer supportMar 18, 2020
@XhmikosRXhmikosR marked this pull request as ready for reviewMarch 18, 2020 07:42
@XhmikosRXhmikosR requested review froma team ascode ownersMarch 18, 2020 07:42
####Escape SVG

We use the`escape-svg` function to escape the`<`,`>` and`#` characters for SVG background images. These characters need to be escaped to properly render the background images in IE.
We use the`escape-svg` function to escape the`<`,`>` and`#` characters for SVG background images.
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This reminds me, maybe we should revisit the escape SVG function later.

MartijnCuppens and ffoodd reacted with thumbs up emoji
@XhmikosRXhmikosR requested a review fromJohann-SMarch 18, 2020 13:27
@rbonomo
Copy link

rbonomo commentedApr 7, 2020
edited
Loading

Supporting IE would be a wise and thoughtful decision. You'll end up with people using a fork that supports IE. Supporting IE is a small challenge to overcome.

There is an ongoing Hacker News discussion that links here for everyone's context:https://news.ycombinator.com/item?id=22802003

Today's reality is that there are IE users, and by not supporting them you are excluding them.

weidenhaus, dlo, sam1rm-hiretech, ron-wolf, cglong, jimbru, and LegoStormtroopr reacted with thumbs up emojijevenson, boghyon, armujahid, dherault, nmstoker, mmdevcodes, rubber-duck, MetricMike, rattrayalex, wmichelin, and 4 more reacted with thumbs down emojirbonomo reacted with eyes emoji

@mohe2015
Copy link

I think they want to keep supporting bootstrap 4.

@mirap
Copy link

mirap commentedApr 7, 2020
edited
Loading

Supporting IE would be a wise and thoughtful decision. You'll end up with people using a fork that supports IE. Supporting IE is a small challenge to overcome.

There is an ongoing Hacker News discussion that links here for everyone's context:https://news.ycombinator.com/item?id=22802003

Today's reality is that there are IE users, and by not supporting them you are excluding them.

Supporting Macromedia Flash would be a wise and thoughtful decision. Supporting Macromedia Flash is a small challenge to overcome.

Today's reality is that there are Macromedia Flash users, and by not supporting them you are excluding them.

#vogonpoetry

dlo, ron-wolf, cglong, jimbru, 1blockologist, LegoStormtroopr, and s-i-l-k-e reacted with thumbs down emojiron-wolf and cglong reacted with confused emojiavit and Joshuatanderson reacted with heart emojirbonomo and joedaimarg reacted with eyes emoji

@withinboredom
Copy link

Supporting IE would be a wise and thoughtful decision. You'll end up with people using a fork that supports IE. Supporting IE is a small challenge to overcome.

There is an ongoing Hacker News discussion that links here for everyone's context:https://news.ycombinator.com/item?id=22802003

Today's reality is that there are IE users, and by not supporting them you are excluding them.

I think it’s more useful to point out which demographic would be using internet explorer instead of just saying “some users use it.” Such as military, government, schools, corporations, etc. These demographics are not reflected well in caniuse due to the fact that they’re already excluded from most of the popular web. However, these demographics are the most likely to use a framework such as this one, albeit, internally.

You may be shooting yourself in the foot here.

LegoStormtroopr reacted with thumbs up emoji

@LegoStormtroopr
Copy link

To everyone saying, if you want to keep supporting IE just use Bootstrap4,Bootstrap4 is End-Of-Life at the end of this year:

image

The decision to drop IE support is understandable, but as@withinboredom pointed out a lot of the education, government and big banking sectors still use IE (and do so with Microsofts blessing).
Also there are a lot of startups that support these industries, so its not always a case of saying "hey if they are so big, just change the policy".

Remove IE support from Bootstrap5, but at least give ussome longer support for Bootstrap4.

s-i-l-k-e and withinboredom reacted with thumbs up emoji

@keithn
Copy link

I think if you remove it, bootstrap no longer becomes a simple choice. BS5 suddenly turns into a bet, where BS4 is a safer bet, but it will become unmaintained.

In my experience, the majority of IE11 users are often the users with $s who want to pay for products. Mostly because they are bigger companies/organizations.

tough choice.

@mdo
Copy link
Member

mdo commentedApr 8, 2020

This is the same issue as moving from v3 to v4 when we dropped support for IE9, and the same as moving from v2 to v3 when we dropped IE8. You can still use the older versions despite new ones coming out.

@twbstwbs locked and limited conversation to collaboratorsApr 8, 2020
@XhmikosR
Copy link
MemberAuthor

Just to give some context.

We went back and forth with this issue for quite some time. I, myself, was in favor of keeping IE support until it became an issue for us. In our last team call, we evaluated the pros and cons of keeping IE support and the pros outweigh the cons.

  1. v4 will be supported for quite some time which means people who want to support IE can still use this version, like people could use v3 after v4 was released and we kept supporting it for a long time.
  2. Dropping IE support isn't something we decided to do out of spite or something; it really allows us to improve things for everyone else. And by seeing the numbers, the people that will benefit are multiple times more.
  3. The first clear gain of dropping IE is the use of CSS variables. Our CSS size (bootstrap.min.css) is already down by10%, and the decrease will keep getting bigger. Less CSS is always better for everyone.
  4. The JS size is also down; there are almost no polyfills needed for the features we use, and let's not forget the jQuery removal in v5

Now, in an ideal world we could have all of the above. But our world is not ideal.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mdomdomdo approved these changes

@MartijnCuppensMartijnCuppensMartijnCuppens approved these changes

@Johann-SJohann-SAwaiting requested review from Johann-S

+1 more reviewer

@ysdsysdsysds approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

13 participants
@XhmikosR@abarreraaponte@richlira@Johann-S@rbonomo@mohe2015@mirap@withinboredom@LegoStormtroopr@keithn@mdo@ysds@MartijnCuppens

[8]ページ先頭

©2009-2025 Movatter.jp