Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

remove .form-group leftovers#29449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
MartijnCuppens merged 1 commit intotwbs:masterfromwojtask9:form_group_leftover
Dec 9, 2019

Conversation

wojtask9
Copy link
Contributor

.form-group was removed in#28450

NOTE: Also removed wholelabel styling inside.form-inline andvertical-align from.form-control but I'm not sure about this. My tests shows that everything is OK but maybe my thinking is wrong.

@wojtask9wojtask9 requested a review froma team as acode ownerSeptember 26, 2019 14:23
@wojtask9wojtask9 changed the titleremove form-group leftoversremove .form-group leftoversSep 26, 2019
@MartijnCuppens
Copy link
Member

NOTE: Also removed whole label styling inside .form-inline and vertical-align from .form-control but I'm not sure about this. My tests shows that everything is OK but maybe my thinking is wrong.

Leave these changes for now, we'll probably gonna rely on the new grid to replace.form-inline (See#28517 orhttps://deploy-preview-28517--twbs-bootstrap.netlify.com/docs/4.3/forms/layout/#inline-forms)

Copy link
Member

@MartijnCuppensMartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I removed the changes to.form-inline for now

@MartijnCuppensMartijnCuppens merged commit043b054 intotwbs:masterDec 9, 2019
olsza pushed a commit to olsza/bootstrap that referenced this pull requestOct 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@MartijnCuppensMartijnCuppensMartijnCuppens approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wojtask9@MartijnCuppens@ysds
[8]ページ先頭
©2009-2025 Movatter.jp