- Notifications
You must be signed in to change notification settings - Fork10
Expose prepared statements#27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
2fa47f9 to5401452Comparetvandinther commentedAug 31, 2024
Wondering if I revert this to commit5401452 The current implementation isn't ideal. However, need to solve the issue in5401452 where getting the first row of a queried statement after it was reset returns a row with a null pointer which creates a column type array with an enum value of 0 which is invalid. Seems like there is some kind of cursor reset somewhere? |
fb175d7 to85e5e7bComparetvandinther commentedAug 31, 2024
Waiting for fix to C bindings to be merged upstreamtursodatabase/libsql#1713 |
tvandinther commentedSep 23, 2024
Upstream fix has been merged. This branch requires an update to the revision of libsql being built to include it. |
tvandinther commentedAug 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Update: This feature requires some extra FFI bindings as defined in this branch/fork:https://github.com/tvandinther/libsql/tree/add-missing-statement-functions It appears that |
b4fdef5 to2b3c305Compare
Uh oh!
There was an error while loading.Please reload this page.
Closes#25
This MR implements an interface to expose prepared statements. The internals are also changed to support this new feature.
Public interface changes are present in this MR.
Parameter binding implementation
Bound parameters are held internally in C# and are bound late when the statement is sent for execution. Resetting the statement currently creates a new prepared statement. A change to the bindings code needs to be made to make this both performant and to prevent new bindings from being made.