Commit4b5e50c

authored

Support trino type query (#129)

* Support Trino query type* Correct mock query call

1 parent3de0350 commit4b5e50cCopy full SHA for 4b5e50c

File tree

+17

-2

lines changed

+17

-2

lines changed

Lines changed: 1 addition & 0 deletions

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,7 @@ def query(`
`248`	`248`	`ValueError: if unknown query type has been specified`
`249`	`249`	`"""`
`250`	`250`	`# for compatibility, assume type is hive unless specifically specified`
`251`		`-iftypenotin ["hive","pig","impala","presto"]:`
	`251`	`+iftypenotin ["hive","pig","impala","presto","trino"]:`
`252`	`252`	`raiseValueError("The specified query type is not supported: %s"% (type))`
`253`	`253`	`job_id=self.api.query(`
`254`	`254`	`q,`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -390,7 +390,7 @@ def query(`
`390`	`390`
`391`	`391`	`Args:`
`392`	`392`	`q (str): Query string.`
`393`		- type (str): Query type. `hive`, `presto`, `bulkload`. Default: `hive`
	`393`	+ type (str): Query type. `hive`, `presto`, `trino`, `bulkload`. Default: `hive`
`394`	`394`	`db (str): Database name.`
`395`	`395`	`result_url (str): Result output URL. e.g.,`
`396`	`396`	``postgresql://<username>:<password>@<hostname>:<port>/<database>/<table>``

Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -197,6 +197,20 @@ def test_query():`
`197`	`197`	`)`
`198`	`198`	`assertjob.job_id=="12345"`
`199`	`199`
	`200`	`+deftest_trino_query():`
	`201`	`+td=client.Client("APIKEY")`
	`202`	`+td._api=mock.MagicMock()`
	`203`	`+td._api.query=mock.MagicMock(return_value=("12345"))`
	`204`	`+job=td.query("sample_datasets","SELECT 1",type="trino")`
	`205`	`+td.api.query.assert_called_with(`
	`206`	`+"SELECT 1",`
	`207`	`+db="sample_datasets",`
	`208`	`+type="trino",`
	`209`	`+retry_limit=None,`
	`210`	`+priority=None,`
	`211`	`+result_url=None,`
	`212`	`+ )`
	`213`	`+assertjob.job_id=="12345"`
`200`	`214`
`201`	`215`	`deftest_jobs():`
`202`	`216`	`td=client.Client("APIKEY")`

Comments

(0)