- Notifications
You must be signed in to change notification settings - Fork140
Allow models.PROTECT in the models#97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Catch exception 'ProtectedError' when try to remove a pk with a relation in the model.Only have to define "on_delete=models.PROTECT" in the model fields.
trco commentedApr 10, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@monsanto-pinheiro Thanks for your PR, however I can't consider it unless it includes test for the change. Please add a test and I would gladly approve this PR. |
monsanto-pinheiro commentedApr 10, 2020
I only did tests for 'tests_unit'. I didn't for functional. Please, can you do it? |
trco commentedJul 1, 2023
@monsanto-pinheiro Same as in#126 (comment). Sorry for not including your PR back in 2020. I'm again working on this package from time to time thus I would like to ask you if you're interested in adjusting this outdated PR to the current code. It would be great to have you as collaborator. Otherwise I would like to thank you for your contribution and include your idea in one of the next releases. |
Catch exception 'ProtectedError' when try to remove a pk with a relation in the model.
Only have to define "on_delete=models.PROTECT" in the model fields.