Un-hardcode the supported factors again#1377

Merged

gaborbernat merged 1 commit intotox-dev:masterfrom

asottile:no_hardcode_again

Jul 27, 2019

Merged

Un-hardcode the supported factors again#1377
gaborbernat merged 1 commit intotox-dev:masterfrom
asottile:no_hardcode_again

Conversation

Copy link

Contributor

asottile commentedJul 25, 2019

Resolves#1374

This also fixes some other things which regressed in#983 -- notably this

$tox -e py21 --notest&& .tox/py21/bin/python --versionpy21 create: /tmp/tox/.tox/py21py21 installdeps: pip == 19.1.1py21 inst: /tmp/tox/.tox/.tmp/package/1/tox-3.13.3.dev7+g84c4c8d.tar.gzpy21 installed: apipkg==1.5,atomicwrites==1.3.0,attrs==19.1.0,coverage==4.5.3,execnet==1.6.1,filelock==3.0.12,flaky==3.6.0,freezegun==0.3.12,importlib-metadata==0.18,more-itertools==7.2.0,packaging==19.0,pathlib2==2.3.4,pluggy==0.12.0,psutil==5.6.3,py==1.8.0,pyparsing==2.4.1.1,pytest==5.0.1,pytest-cov==2.7.1,pytest-forked==1.0.2,pytest-mock==1.10.4,pytest-randomly==1.2.3,pytest-xdist==1.29.0,python-dateutil==2.8.0,six==1.12.0,toml==0.10.0,tox==3.13.3.dev7+g84c4c8d,virtualenv==16.7.1,wcwidth==0.1.7,zipp==0.5.2_______________________________________________________________________ summary ________________________________________________________________________  py21: skipped tests  congratulations :)Python 3.6.8

restored behaviour:

$.tox/py36/bin/tox -e py21 --notestpy21 create: /tmp/tox/.tox/py21SKIPPED: InterpreterNotFound: python2.1_______________________________________________________________________ summary ________________________________________________________________________SKIPPED:  py21: InterpreterNotFound: python2.1  congratulations :)

asottile requested review fromgaborbernat andobestwalter ascode owners

July 25, 2019 22:18

Copy link

todobot commentedJul 25, 2019

(stephenfin): Raise an exception here in tox 4.0

tox/src/tox/config/__init__.py

Lines 577 to 582 in84c4c8d

	# TODO(stephenfin): Raise an exception here in tox 4.0
	warnings.warn(
	"conflicting basepython version (set {}, should be {}) for env '{}';"
	"resolve conflict or set ignore_basepython_conflict".format(
	proposed_version,implied_version,testenv_config.envname
	)