NotificationsYou must be signed in to change notification settings
Fork2
Star4

Commit138cb19

committed

[Front-end] Markup and CSS refinements

Fixesnasa#1729Internal markup and CSS now sets heightsinternally - menu height will now not be smallerthan the list of menu items OR the descriptionarea;

1 parente9cb5cd commit138cb19Copy full SHA for 138cb19

File tree

5 files changed

+189

-152

lines changed

platform
- commonUI
  - edit/res/templates/create
    - create-button.html
    - create-menu.html
  - general/res/sass/controls
    - _menus.scss
- features/conductor/core/res/templates/mode-selector
  - mode-menu.html
  - mode-selector.html

5 files changed

+189

-152

lines changed

`‎platform/commonUI/edit/res/templates/create/create-button.html‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`<divclass="s-menu-button major create-button"ng-click="createController.toggle()">`
`24`	`24`	`<spanclass="title-label">Create</span>`
`25`	`25`	`</div>`
`26`		`-<divclass="menu super-menu"ng-show="createController.isActive()">`
	`26`	`+<divclass="menu super-menu l-create-menu"ng-show="createController.isActive()">`
`27`	`27`	`<mct-representationmct-object="domainObject"key="'create-menu'">`
`28`	`28`	`</mct-representation>`
`29`	`29`	`</div>`

`‎platform/commonUI/edit/res/templates/create/create-menu.html‎`

Lines changed: 7 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,11 +33,13 @@`
`33`	`33`	`</div>`
`34`	`34`	`<divclass="col menu-item-description">`
`35`	`35`	`<divclass="desc-area icon {{ representation.activeMetadata.cssClass }}"></div>`
`36`		`-<divclass="desc-area title">`
`37`		`- {{representation.activeMetadata.name}}`
`38`		`-</div>`
`39`		`-<divclass="desc-area description">`
`40`		`- {{representation.activeMetadata.description}}`
	`36`	`+<divclass="w-title-desc">`
	`37`	`+<divclass="desc-area title">`
	`38`	`+ {{representation.activeMetadata.name}}`
	`39`	`+</div>`
	`40`	`+<divclass="desc-area description">`
	`41`	`+ {{representation.activeMetadata.description}}`
	`42`	`+</div>`
`41`	`43`	`</div>`
`42`	`44`	`</div>`
`43`	`45`	`</div>`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit138cb19

File tree

5 files changed

5 files changed

`‎platform/commonUI/edit/res/templates/create/create-button.html‎`

`‎platform/commonUI/edit/res/templates/create/create-menu.html‎`

0 commit comments