Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Issue4380 : Removed proxyApi and TEMP fix to registrants#190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sushilshinde merged 3 commits intointegration-v5-challenge-apifromissue-4380-v2
Jun 12, 2020
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion__tests__/__snapshots__/index.js.snap
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -291,7 +291,6 @@ Object {
"getApiV4": [Function],
"getApiV5": [Function],
"getTcM2mToken": [Function],
"proxyApi": [Function],
},
"billing": Object {
"default": [Function],
Expand Down
18 changes: 0 additions & 18 deletionssrc/services/api.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -290,21 +290,3 @@ export async function getTcM2mToken() {
const token = await m2m.getMachineToken(TC_M2M.CLIENT_ID, TC_M2M.CLIENT_SECRET);
return token;
}

/**
* Call API via proxy
*
* @param {String} url to API endpoint
*/
export async function proxyApi(endpoint) {
let domain = '';
if (isomorphy.isServerSide()) {
domain = `http://${config.ENV.HOST || 'localhost'}:${config.ENV.PORT || 3000}`;
}
const url = `${domain}/community-app-assets/api${endpoint}`;
let res = await fetch(url);
if (!res.ok) throw new Error(res.statusText);
res = (await res.json());
if (res.message) throw new Error(res.message);
return res;
}
39 changes: 33 additions & 6 deletionssrc/services/challenges.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@ import { decodeToken } from 'tc-accounts';
import logger from '../utils/logger';
import { setErrorIcon, ERROR_ICON_TYPES } from '../utils/errors';
import { COMPETITION_TRACKS, getApiResponsePayload } from '../utils/tc';
import { getApi, proxyApi } from './api';
import { getApi } from './api';
import { getService as getMembersService } from './members';

export const ORDER_BY = {
Expand DownExpand Up@@ -200,7 +200,6 @@ class ChallengesService {
apiV3: getApi('V3', tokenV3),
getChallenges,
getMemberChallenges,
proxyApi,
tokenV2,
tokenV3,
memberService: getMembersService(),
Expand DownExpand Up@@ -326,8 +325,10 @@ class ChallengesService {
* @return {Promise} Resolves to the challenge object.
*/
async getChallengeDetails(challengeId) {
const user = decodeToken(this.private.tokenV3);
let challenge = {};
let isLegacyChallenge = false;
let isRegistered = false;
// condition based on ROUTE used for Review Opportunities, change if needed
if (/^[\d]{5,8}$/.test(challengeId)) {
isLegacyChallenge = true;
Expand All@@ -338,10 +339,22 @@ class ChallengesService {
.then(res => res.challenges);
}

const registrants = await this.getChallengeRegistrants(challenge.id);
challenge.registrants = registrants;
// TEMP FIX until API was fixed
try {
const registrants = await this.getChallengeRegistrants(challenge.id);
challenge.registrants = registrants;
} catch (err) {
challenge.registrants = [];
}

if (user) {
const userChallenges = await this.private.apiV5.get(`/resources/${user.userId}/challenges`)
.then(checkErrorV5).then(res => res.result);
isRegistered = _.includes(userChallenges, challengeId);
}

challenge.isLegacyChallenge = isLegacyChallenge;
challenge.isRegistered = isRegistered;

challenge.events = _.map(challenge.events, e => ({
eventName: e.key,
Expand All@@ -360,7 +373,19 @@ class ChallengesService {
* @return {Promise} Resolves to the challenge registrants array.
*/
async getChallengeRegistrants(challengeId) {
const registrants = await this.private.proxyApi(`/challenges/${challengeId}/registrants`);
const roleId = await this.getRoleId('Submitter');
const params = {
challengeId,
roleId,
};

const registrants = await this.private.apiV5.get(`/resources?${qs.stringify(params)}`)
.then(checkErrorV5).then(res => res.result);

if (_.isEmpty(registrants)) {
throw new Error('Resource Role not found!');
}

return registrants || [];
}

Expand DownExpand Up@@ -526,8 +551,10 @@ class ChallengesService {
async getRoleId(roleName) {
const params = {
name: roleName,
isActive: true,
};
const roles = await this.private.proxyApi(`/challenges/roleId?${qs.stringify(params)}`);
const roles = await this.private.apiV5.get(`/resource-roles?${qs.stringify(params)}`)
.then(checkErrorV5).then(res => res.result);

if (_.isEmpty(roles)) {
throw new Error('Resource Role not found!');
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp