Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Issue 4380 : Fix challenge register/unregister#187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sushilshinde merged 5 commits intointegration-v5-challenge-apifromissue-4380-v2
Jun 11, 2020
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions__tests__/__snapshots__/index.js.snap
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -291,6 +291,7 @@ Object {
"getApiV4": [Function],
"getApiV5": [Function],
"getTcM2mToken": [Function],
"proxyApi": [Function],
},
"billing": Object {
"default": [Function],
Expand Down
18 changes: 18 additions & 0 deletionssrc/services/api.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -290,3 +290,21 @@ export async function getTcM2mToken() {
const token = await m2m.getMachineToken(TC_M2M.CLIENT_ID, TC_M2M.CLIENT_SECRET);
return token;
}

/**
* Call API via proxy
*
* @param {String} url to API endpoint
*/
export async function proxyApi(endpoint) {
let domain = '';
if (isomorphy.isServerSide()) {
domain = `http://${config.ENV.HOST || 'localhost'}:${config.ENV.PORT || 3000}`;
}
const url = `${domain}/community-app-assets/api${endpoint}`;
let res = await fetch(url);
if (!res.ok) throw new Error(res.statusText);
res = (await res.json());
if (res.message) throw new Error(res.message);
return res;
}
59 changes: 31 additions & 28 deletionssrc/services/challenges.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@ import { decodeToken } from 'tc-accounts';
import logger from '../utils/logger';
import { setErrorIcon, ERROR_ICON_TYPES } from '../utils/errors';
import { COMPETITION_TRACKS, getApiResponsePayload } from '../utils/tc';
import { getApi } from './api';
import { getApi, proxyApi } from './api';
import { getService as getMembersService } from './members';

export const ORDER_BY = {
Expand DownExpand Up@@ -200,6 +200,7 @@ class ChallengesService {
apiV3: getApi('V3', tokenV3),
getChallenges,
getMemberChallenges,
proxyApi,
tokenV2,
tokenV3,
memberService: getMembersService(),
Expand DownExpand Up@@ -325,27 +326,32 @@ class ChallengesService {
* @return {Promise} Resolves to the challenge object.
*/
async getChallengeDetails(challengeId) {
let challenge = {};
let isLegacyChallenge = false;
const filters = {};
// condition based on ROUTE used for Review Opportunities, change if needed
if (challengeId.length >= 5 && challengeId.length <= 8) {
if (/^[\d]{5,8}$/.test(challengeId)) {
isLegacyChallenge = true;
filters.legacyId = challengeId;
challenge = await this.private.getChallenges('/challenges/', { legacyId: challengeId })
.then(res => res.challenges[0]);
} else {
filters.id = challengeId;
challenge = await this.private.getChallenges(`/challenges/${challengeId}`)
.then(res => res.challenges);
}
const challengeFiltered = await this.private.getChallenges('/challenges/', filters)
.then(res => res.challenges[0]);

if (challengeFiltered) {
challengeFiltered.isLegacyChallenge = isLegacyChallenge;
challengeFiltered.events = _.map(challengeFiltered.events, e => ({
eventName: e.key,
eventId: e.id,
description: e.name,
}));
}
return challengeFiltered;

const registrants = await this.getChallengeRegistrants(challenge.id);
challenge.registrants = registrants;

challenge.isLegacyChallenge = isLegacyChallenge;

challenge.events = _.map(challenge.events, e => ({
eventName: e.key,
eventId: e.id,
description: e.name,
}));

challenge.fetchedWithAuth = Boolean(this.private.apiV5.private.token);

return challenge;
}

/**
Expand All@@ -354,8 +360,7 @@ class ChallengesService {
* @return {Promise} Resolves to the challenge registrants array.
*/
async getChallengeRegistrants(challengeId) {
const registrants = await this.private.apiV5.get(`/resources/challengeId=${challengeId}`)
.then(checkError).then(res => res);
const registrants = await this.private.proxyApi(`/challenges/${challengeId}/registrants`);
return registrants || [];
}

Expand DownExpand Up@@ -518,19 +523,17 @@ class ChallengesService {
* @param {String} roleName
* @return {Promise}
*/
asyncgetResourceRoleId(roleName) {
asyncgetRoleId(roleName) {
const params = {
name: roleName,
isActive: true,
};
const roles = await this.private.apiV5.get(`/resource-roles?${qs.stringify(params)}`)
.then(checkErrorV5).then(res => res);
const roles = await this.private.proxyApi(`/challenges/roleId?${qs.stringify(params)}`);

if (_.isEmpty(roles.result)) {
if (_.isEmpty(roles)) {
throw new Error('Resource Role not found!');
}

return roles.result[0].id;
return roles[0].id;
}

/**
Expand All@@ -540,7 +543,7 @@ class ChallengesService {
*/
async register(challengeId) {
const user = decodeToken(this.private.tokenV3);
const roleId = await this.getResourceRoleId('Submitter');
const roleId = await this.getRoleId('Submitter');
const params = {
challengeId,
memberHandle: user.handle,
Expand All@@ -558,13 +561,13 @@ class ChallengesService {
*/
async unregister(challengeId) {
const user = decodeToken(this.private.tokenV3);
const roleId = await this.getResourceRoleId('Submitter');
const roleId = await this.getRoleId('Submitter');
const params = {
challengeId,
memberHandle: user.handle,
roleId,
};
const res = await this.private.apiV5.delete('/resources', params);
const res = await this.private.apiV5.delete('/resources',JSON.stringify(params));
if (!res.ok) throw new Error(res.statusText);
return res.json();
}
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp