Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(PM-3090): likes dislikes not updated automatically#1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
hentrymartin wants to merge3 commits intodev
base:dev
Choose a base branch
Loading
frompm-3090

Conversation

@hentrymartin
Copy link
Collaborator

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/PM-3090

What's in this PR?

  • Seems like the swr url got changed slighly and it broke the mutation
  • Now updated the mutation url keys to reflect the change
  • This would make the likes/dislikes/comments to be updated automatically.


try{
constitemsKey=`${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun.id}/items`
constitemsKey=`${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun.id}/items?[${workflowRun?.status}]`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[❗❗correctness]
The use of optional chaining withworkflowRun?.status in the URL may lead to unexpected behavior ifworkflowRun isundefined. Consider ensuringworkflowRun is defined before constructing the URL to avoid potential issues.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@jmgasperjmgasperAwaiting requested review from jmgasperjmgasper is a code owner

@kkartunovkkartunovAwaiting requested review from kkartunovkkartunov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hentrymartin

[8]ページ先頭

©2009-2025 Movatter.jp