- Notifications
You must be signed in to change notification settings - Fork21
fix(PM-3065, PM-3074, PM-3076): added back button, ui issues#1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| flex-shrink:0; | ||
| height:20px; | ||
| width:20px; | ||
| @includeltemd { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[❗❗correctness]
Ensure that theltemd mixin is defined and behaves as expected. If it's not defined in this file, verify its definition elsewhere to confirm it applies the intended styles correctly.
| try{ | ||
| if(challengeInfo?.id){ | ||
| // Ensure the challenge details reflect the latest data (e.g., active phase) | ||
| awaitmutate(`challengeBaseUrl/challenges/${challengeInfo?.id}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[❗❗correctness]
Themutate function is called with a hardcoded stringchallengeBaseUrl/challenges/${challengeInfo?.id}. Ensure thatchallengeBaseUrl is defined and correctly imported or used here, as it is not shown in the diff. If it's a typo or missing import, it could lead to runtime errors.
| constpastPrefix='/past-challenges/' | ||
| // eslint-disable-next-line no-restricted-globals | ||
| constidx=location.pathname.indexOf(pastPrefix) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[correctness]
Usinglocation.pathname directly can be problematic in environments wherelocation is not defined, such as during server-side rendering. Consider using a safer method to access the current path that is compatible with both client and server environments.
ff77f1c intodevUh oh!
There was an error while loading.Please reload this page.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-3065
https://topcoder.atlassian.net/browse/PM-3074
https://topcoder.atlassian.net/browse/PM-3076
What's in this PR?