Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

PM- 1760#7109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
himaniraghav3 merged 5 commits intov6fromPM-1760
Sep 11, 2025
Merged

PM- 1760#7109

himaniraghav3 merged 5 commits intov6fromPM-1760
Sep 11, 2025

Conversation

himaniraghav3
Copy link
Collaborator

Updates the review opportunity list to use the review API endpoint.
Also moves the necessary code fromtopcoder-react-lib toCommunity App

kkartunov reacted with thumbs up emoji
update the review opportunity bucket to work with new review apiFixes#1760
normalise response and testFixes #PM-1760
Previously, the filter function was defined in topcoder-react-libFixes#1760

returnfetch(url.toString(),{
method:'GET',
}).then(res=>res.json());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consider adding error handling for the fetch request to manage potential network errors or unsuccessful responses. This will improve the robustness of the function.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@himaniraghav3 - Thoughts on this one?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, I left it unresolved so reviewers could cross check. I'll add error handling

remove unnecessary paramFixes#1760
Copy link
Collaborator

@jmgasperjmgasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good - just wondering if we need the error handling mentioned by the AI reviewer on the API call.


returnfetch(url.toString(),{
method:'GET',
}).then(res=>res.json());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@himaniraghav3 - Thoughts on this one?

Copy link
Collaborator

@kkartunovkkartunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good

Adds error handling to the API call for fetching review opportunitiesFixes#1760
*@param {number} pageSize - Number of items per page.
*@returns {Promise<Object>} The fetched data.
*/
exportdefaultasyncfunctiongetReviewOpportunities(page,pageSize){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consider adding error handling for network errors that might occur during the fetch operation. Currently, only HTTP errors are handled.

@himaniraghav3himaniraghav3 merged commitb5ce064 intov6Sep 11, 2025
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@jmgasperjmgasperjmgasper approved these changes

@kkartunovkkartunovkkartunov approved these changes

@vas3avas3aAwaiting requested review from vas3a

@ajeftsajeftsAwaiting requested review from ajeftsajefts is a code owner

@luizrrodriguesluizrrodriguesAwaiting requested review from luizrrodriguesluizrrodrigues is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@himaniraghav3@jmgasper@kkartunov
[8]ページ先頭
©2009-2025 Movatter.jp