- Notifications
You must be signed in to change notification settings - Fork211
Grab the Topgear submission changes#7100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Prod release - Security issues - Community App PHASE 2
PROD RELEASE - Features in CA related to deprecating Submission Review UI app
PROD RELEASE - Topgear - Submission URL validation
PROD - Topgear challenges - Submissions Guidelines Text needs to be updated in submit page
PROD - Topgear challenges - Submissions urls
[PROD RELEASE] - Bug fixes
…ission-urlsHOTFIX PM-967 tg submission urls
| INNOVATION_CHALLENGES_TAG:'Innovation Challenge', | ||
| PLATFORM_SITE_URL:'https://platform.topcoder-dev.com', | ||
| TOPGEAR_ALLOWED_SUBMISSIONS_DOMAINS:['wipro365.sharepoint.com','wipro365-my.sharepoint.com','wipro365-my.sharepoint.com.mcas.ms'], | ||
| TOPGEAR_ALLOWED_SUBMISSIONS_DOMAINS:'wipro365.sharepoint.com|wipro365-my.sharepoint.com|wipro365-my.sharepoint.com.mcas.ms', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The change from an array to a string forTOPGEAR_ALLOWED_SUBMISSIONS_DOMAINS may affect how this configuration is used in the application. If the application logic expects an array, this change could lead to errors. Consider verifying that the application can handle a string with domains separated by| or update the logic accordingly.
| isDomainAllowed(url){ | ||
| constdomainReg=newRegExp(`^https?://(${config.TOPGEAR_ALLOWED_SUBMISSIONS_DOMAINS.join('|')})/.+`); | ||
| constdomainReg=newRegExp(`^https?://(${config.TOPGEAR_ALLOWED_SUBMISSIONS_DOMAINS})/.+`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The change fromjoin('|') to directly usingconfig.TOPGEAR_ALLOWED_SUBMISSIONS_DOMAINS might cause issues ifTOPGEAR_ALLOWED_SUBMISSIONS_DOMAINS is an array. If it is intended to be a single string, ensure that it is formatted correctly as a regex pattern. Otherwise, if it is an array, the previous implementation usingjoin('|') is necessary to construct a valid regex pattern that matches any of the allowed domains.
74bc5c9 intodevelopUh oh!
There was an error while loading.Please reload this page.
No description provided.