- Notifications
You must be signed in to change notification settings - Fork211
[PROD RELEASE] - Bug fixes#7093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fix(PM-1192): showing wrong review scorecard link
Previously, the sorting failed when getFinal() returned undefined. Now we fallback to getSubmissionDate() in case of anonymous userFixes PM-1055
Fix(registrants): sort by submitted date correctly
| phases, | ||
| }=challenge; | ||
| constgetScoreCardByPhase=(phaseName)=>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Consider adding error handling or a default return value ingetScoreCardByPhase in casephases is undefined or does not contain the expected structure. This will prevent potential runtime errors.
| }=challenge; | ||
| constgetScoreCardByPhase=(phaseName)=>{ | ||
| constphase=phases.find(item=>item.name===phaseName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thefind method will returnundefined if no matching phase is found. Ensure thatphase is checked before attempting to accessphase.constraints to avoid potential errors.
| constgetScoreCardByPhase=(phaseName)=>{ | ||
| constphase=phases.find(item=>item.name===phaseName); | ||
| constscoreCardConstraint=phase&&phase.constraints&&phase.constraints.find(item=>item.name==='Scorecard'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Consider checking ifphase.constraints is an array before callingfind on it to prevent runtime errors ifconstraints is not defined or not an array.
| }), | ||
| metadata:PT.array, | ||
| events:PT.arrayOf(PT.string), | ||
| phases:PT.arrayOf(PT.any), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
UsingPT.any forphases prop type is not specific and can lead to potential issues with type checking. Consider defining a more specific prop type that accurately reflects the expected structure of thephases array.
609d44c intomasterUh oh!
There was an error while loading.Please reload this page.
https://topcoder.atlassian.net/browse/PM-1055
https://topcoder.atlassian.net/browse/PM-1192