- Notifications
You must be signed in to change notification settings - Fork6
Add scorecard and phase ID checks to the reviewer checks#56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bdbcfcc intodevelopUh oh!
There was an error while loading.Please reload this page.
| data:{ | ||
| id:uuid(), | ||
| challengeId:activationChallenge.id, | ||
| scorecardId:'', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[❗❗correctness]
ThescorecardId is set to an empty string. Ensure that this is intentional and that the system can handle an emptyscorecardId without causing issues. If ascorecardId is required, consider adding validation to prevent empty values.
| should.equal(e.message.indexOf('reviewers are missing required fields')>=0,true) | ||
| return | ||
| }finally{ | ||
| awaitprisma.challenge.delete({where:{id:activationChallenge.id}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[maintainability]
Thefinally block deletes theactivationChallenge regardless of whether thecatch block is executed. Ensure that this deletion is intended in all cases, as it may affect test isolation or subsequent tests.
No description provided.