Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(PM-2540): added ai workflow id to default reviewer#52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hentrymartin merged 4 commits intodevelopfrompm-2540_3
Nov 12, 2025

Conversation

@hentrymartin
Copy link
Collaborator

What's in this PR?

  • Added aiWorkflowId to DefaultChallengeReviewer schema
  • Added logic to save and retrieve it using default-challenge-reviewer API endpoints

timelineTemplateIdString?
// Reviewer configuration (mirrors ChallengeReviewer)
scorecardIdString
scorecardIdString?
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@kkartunov@jmgasper fyi, I am making scorecardId field nullable as default AI reviewers can be created without a scorecard.

kkartunov reacted with thumbs up emoji
incrementalCoefficientFloat?
opportunityTypeReviewOpportunityTypeEnum?
isAIReviewerBoolean?
aiWorkflowIdString?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@hentrymartin modify the type toString? @db.VarChar(14) as per ticket spec.

@kkartunovkkartunov self-requested a reviewNovember 12, 2025 16:26
*/
-- AlterTable
ALTERTABLE"DefaultChallengeReviewer" DROP COLUMN"isAIReviewer",
ADD COLUMN"aiWorkflowId"VARCHAR(14),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[⚠️performance]
Consider usingCHAR(14) instead ofVARCHAR(14) if theaiWorkflowId is always expected to be exactly 14 characters long. This can improve performance slightly and ensure data consistency.

incrementalCoefficientFloat?
opportunityTypeReviewOpportunityTypeEnum?
isAIReviewerBoolean?
aiWorkflowIdString?@db.VarChar(14)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[❗❗correctness]
The@db.VarChar(14) annotation specifies a maximum length for theaiWorkflowId field. Ensure that this length is sufficient for all potential values, as truncation could lead to data loss or errors when storing longer IDs.

@@index([timelineTemplateId])
@@index([timelineTemplateId,phaseId])
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[💡style]
The lack of a newline at the end of the file can cause issues with some tools and version control systems. Consider adding a newline to improve compatibility.

Copy link
Contributor

@kkartunovkkartunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good

@hentrymartinhentrymartin merged commit9a79208 intodevelopNov 12, 2025
6 checks passed
@hentrymartinhentrymartin deleted the pm-2540_3 branchNovember 12, 2025 16:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@kkartunovkkartunovkkartunov approved these changes

@jmgasperjmgasperAwaiting requested review from jmgasper

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hentrymartin@kkartunov

[8]ページ先頭

©2009-2025 Movatter.jp