- Notifications
You must be signed in to change notification settings - Fork6
feat(PM-2540): added ai workflow id to default reviewer#52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
prisma/migrations/20251112162335_aiworkflowid_in_def_challenge_reviewer/migration.sqlShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
prisma/migrations/20251112162335_aiworkflowid_in_def_challenge_reviewer/migration.sqlShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| timelineTemplateIdString? | ||
| // Reviewer configuration (mirrors ChallengeReviewer) | ||
| scorecardIdString | ||
| scorecardIdString? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@kkartunov@jmgasper fyi, I am making scorecardId field nullable as default AI reviewers can be created without a scorecard.
prisma/schema.prisma Outdated
| incrementalCoefficientFloat? | ||
| opportunityTypeReviewOpportunityTypeEnum? | ||
| isAIReviewerBoolean? | ||
| aiWorkflowIdString? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@hentrymartin modify the type toString? @db.VarChar(14) as per ticket spec.
| */ | ||
| -- AlterTable | ||
| ALTERTABLE"DefaultChallengeReviewer" DROP COLUMN"isAIReviewer", | ||
| ADD COLUMN"aiWorkflowId"VARCHAR(14), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[performance]
Consider usingCHAR(14) instead ofVARCHAR(14) if theaiWorkflowId is always expected to be exactly 14 characters long. This can improve performance slightly and ensure data consistency.
| incrementalCoefficientFloat? | ||
| opportunityTypeReviewOpportunityTypeEnum? | ||
| isAIReviewerBoolean? | ||
| aiWorkflowIdString?@db.VarChar(14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[❗❗correctness]
The@db.VarChar(14) annotation specifies a maximum length for theaiWorkflowId field. Ensure that this length is sufficient for all potential values, as truncation could lead to data loss or errors when storing longer IDs.
| @@index([timelineTemplateId]) | ||
| @@index([timelineTemplateId,phaseId]) | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[💡style]
The lack of a newline at the end of the file can cause issues with some tools and version control systems. Consider adding a newline to improve compatibility.
kkartunov left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good
9a79208 intodevelopUh oh!
There was an error while loading.Please reload this page.
What's in this PR?