Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PROD RELEASE] - WM related updates#740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kkartunov wants to merge9 commits intomaster
base:master
Choose a base branch
Loading
fromdev
Open

[PROD RELEASE] - WM related updates#740

kkartunov wants to merge9 commits intomasterfromdev

Conversation

@kkartunov
Copy link
Contributor

uses:actions/checkout@v3

-name:TC AI PR Reviewer
uses:topcoder-platform/tc-ai-pr-reviewer@master

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consider specifying a version tag instead of using@master for thetopcoder-platform/tc-ai-pr-reviewer action to ensure stability and avoid unexpected changes.

with:
GITHUB_TOKEN:${{ secrets.GITHUB_TOKEN }}# The GITHUB_TOKEN is there by default so you just need to keep it like it is and not necessarily need to add it as secret as it will throw an error. [More Details](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret)
LAB45_API_KEY:${{ secrets.LAB45_API_KEY }}
exclude:"**/*.json, **/*.md, **/*.jpg, **/*.png, **/*.jpeg, **/*.bmp, **/*.webp"# Optional: exclude patterns separated by commas

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ensure that the exclude patterns are correctly formatted and cover all necessary file types that should be excluded from the review process. Double-check if any additional file types need to be added to the exclusion list.

constcanAccesChallenge=_.isUndefined(currentUser)
?false
:currentUser.isMachine||hasAdminRole(currentUser)||!_.isEmpty(memberResources);
:currentUser.isMachine||hasAdminRole(currentUser)||hasProjectManagerRole(currentUser)||!_.isEmpty(memberResources);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is a typo in the variable namecanAccesChallenge. It should becanAccessChallenge to maintain consistency and readability.

functionhasProjectManagerRole(authUser){
if(authUser&&authUser.roles){
for(constroleofauthUser.roles){
if(role.toLowerCase()===constants.UserRoles.ProjectManager.toLowerCase()){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consider usinglocaleCompare for case-insensitive comparison instead oftoLowerCase() to handle edge cases with locale-specific characters.

];

const_hasAdminRole=hasAdminRole(currentUser);
const_hasProjectManagerRole=hasProjectManagerRole(currentUser);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consider checking ifhasProjectManagerRole function is defined and imported correctly to ensure it works as expected.

letexcludeTasks=true;
// if you're an admin or m2m, security rules wont be applied
if(currentUser&&(_hasAdminRole||_.get(currentUser,"isMachine",false))){
if(currentUser&&(_hasAdminRole||_hasProjectManagerRole||_.get(currentUser,"isMachine",false))){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The variable_hasProjectManagerRole is used here, but it's not clear from the diff if it is defined or initialized anywhere in the code. Ensure that_hasProjectManagerRole is properly defined and initialized before this line to avoid potential runtime errors.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kkartunov@hentrymartin@jmgasper

[8]ページ先頭

©2009-2025 Movatter.jp