Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Fix issue with urlencoded user handles#1221

Open
ThomasKranitsas wants to merge2 commits intotopcoder-archive:dev
base:dev
Choose a base branch
Loading
fromThomasKranitsas:member-profile-urls

Conversation

@ThomasKranitsas
Copy link
Contributor

Fixes#1220

Note that I had to update thestart command towebpack-dev-server --history-api-fallback --host 0.0.0.0 --dev --tc --inline --progress --port 3000 --public local.topcoder-dev.com:3000 in order to run the app locally on MacOS..

@birdofpreyru
Copy link
Collaborator

There is an issue:

  1. I have deployed locally and run atlocal.topcoder.com;
  2. I go tohttp://local.topcoder.com/members/[[iwi]] - it loads the profile, but replaces URL byhttp://local.topcoder.com/members/%255B%255Biwi%255D%255D/, which is an incorrect URL encoding for [[iwi]] (the correct one is %5B%5Biwi%5D%5D). If I know remove the trailing/ and press reload the page, it goes to 404.
  3. Similarlyhttp://local.topcoder.com/members/John%20Dethridge, when accessed, replaces URL byhttp://local.topcoder.com/members/John%2520Dethridge/, which goes to 404, if I remove the trailing/.

This should be polished to ensure that current URL is encoded/decoded correctly.

@ThomasKranitsas
Copy link
ContributorAuthor

@birdofpreyru this is a double encoding issue.. I managed to recursively decode therouteParam and get the app working even if the URL ishttp://local.topcoder-dev.com:3000/members/%252525255B%252525255Biwi%252525255D%252525255D/ ([[iwi]])

I'm trying to prevent the double encoding to avoid such ugly URLs..

I'll push a commit shortly.

birdofpreyru reacted with thumbs up emoji

@birdofpreyru
Copy link
Collaborator

@ThomasKranitsas Cool!
Actually, I don't see why we need to replace the URL in such case at all? If we manage to load the profile, when[[iwi]] is inside the URL, why do we need to replace it with URL-encoded one? Also, when there is trailing/ no such replacement take place.

@ThomasKranitsas
Copy link
ContributorAuthor

@birdofpreyru that's what I'm trying to do actually :)

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ThomasKranitsas@birdofpreyru

[8]ページ先頭

©2009-2025 Movatter.jp