- Notifications
You must be signed in to change notification settings - Fork237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
test: change octal escape to Unicode escape#295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When performing an eslint-driven security audit (using `babel-eslint` and looking for things like `eval`), I got this parsing error preventing me from auditing here. I've therefore converted this octal escape to a Unicode escape, and since it should be treated exactly the same (and would be needed if you ever went to strict mode), I figure I'd submit the fix.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing an eslint-driven security audit (using
babel-eslintand looking for things likeeval), I got this parsing error in your test file, preventing me from auditing here.I've therefore converted this octal escape to a Unicode escape, and since it should be treated exactly the same (and would be needed if you ever went to strict mode), I figure I'd submit the fix, especially if you didn't want to just ignore the test folder in a future release.
Thanks!