- Notifications
You must be signed in to change notification settings - Fork1k
test(usb): create usb.Controller interface for testing#5110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
0ce6776 to7fc576bComparedeadprogram commentedDec 6, 2025
@mikesmitty can you please resolve merge conflicts so I can help review. Thank you! |
7fc576b to64281dfComparemikesmitty commentedDec 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I pushed up some changes to make it compatible with the change to disable USB-CDC when -serial=(uart|rtt), but the relevant nrf52840 code for example is still broken in this one. Now that the base is updated with the CSW fixes I'm back to working on that portion again though. Since this depends on changes to the nrf52840 and samd usb stacks those will need to be fixed before this one can be merged, but I'll be using this branch as the base for them for testing/debugging |
320364b to3e62c8eCompare
Uh oh!
There was an error while loading.Please reload this page.
I mentioned this in a comment on#5109, this is a small refactor of the machine and usb package interactions (and some other changes mixed in that will be created as separate PRs and rebased later on). This creates a usb.Controller interface for use in the USB-related packages for mocking in unit testing and updates machine.USBDev to implement it: