- Notifications
You must be signed in to change notification settings - Fork967
internal/gclayout: make gclayout values constants#4947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
7336fb2 to0d17fccCompareThe previous versions calculated at init() prevented `interp` from runningin many cases, increasing compile times due to the increased need to revertthe partially interpreted results and also increasing binary runtime becausefewer optimizations had happened during interp.
|
@dgryski please rebase against lastest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, using constants is much better.
Not sure aboutAsPtr but I can't really think of a better name for the method.
@dgryski please remember to rebase against the most recent dev to pass CI |
The previous versions calculated at init() prevented
interpfrom running in many cases, increasing compile times due to the increased need to revert the partially interpreted results and also increasing binary runtime because fewer optimizations had happened during interp.