Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feat/nrf52xxx/spi/improve#4699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
milkpirate wants to merge6 commits intotinygo-org:dev
base:dev
Choose a base branch
Loading
frommilkpirate:feat/nrf52xxx/spi/improve

Conversation

milkpirate
Copy link
Contributor

@milkpiratemilkpirate commentedJan 14, 2025
edited
Loading

As requested per#4660 (review)

What I did

SPI

  • Create SPIMode type
  • Make SPI implement io.Reader, io.Writer
  • Update formatting to align with other switch-cases
  • Update SPI documentation reference

xplshn reacted with heart emoji
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
// set frequency
var freq uint32
switch {
case config.Frequency == 0: // default MCU SPI speed
freq = nrf.SPIM_FREQUENCY_FREQUENCY_M4
Copy link
Contributor

@ysoldakysoldakJan 17, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't see this as improvement :( Previous code looks cleaner to me: separates concerns of a) ensuring default value and b) handling frequency.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Found the separate if-statement superfluous, since we already have a flow control on the frequency.

b0ch3nski reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

can you two@ysoldak,@b0ch3nski agree on that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I find switch statements much easier to read but I think it's just a matter of personal preference. Nevertheless, we already have a switch here and that lonely if statement looks like it has rejoined it's people 😃

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I find switch statements much easier to read but I think it's just a matter of personal preference. Nevertheless, we already have a switch here and that lonely if statement looks like it has rejoined it's people 😃

Yes, felt the same to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Regarding switch, I must confess, I was struggling to understand what's going on at first.
I was expecting every 'case' to produce a unique value (number of unique values = number of cases in switch).
I would propose merge two cases, but then case condition becomes long and look ugly.

So I still prefer deal with default value first, then handle the value, regardless default it is or not.
It may look nice/smart to have only one switch without an extra "if" before it, because we can, but I'd say readability suffers, at least in my case.

Copy link
Contributor

@soypatsoypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

machine package breaking changes must be discussed beforehand. And some nits

Comment on lines +341 to +350
// Read implements [io.Reader]. And reads as many bytes as the given buffer is long
func (spi *SPI) Read(r []byte) (int, error) {
return len(r), spi.Tx(nil, r)
}

// Write implements [io.Writer]. And writes as long as there are bytes in w.
func (spi *SPI) Write(w []byte) (int, error) {
return len(w), spi.Tx(w, nil)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Read and Write are not part of the SPI interface. It is easy enough to implement an abstraction if needed that works for all SPI hardwares of all MCUs

funcwriteSPI(w []byte,spiinterface {Tx(w,r []byte)error}) (int,error) {returnlen(w),spi.Tx(w,nil)}

Copy link
ContributorAuthor

@milkpiratemilkpirateJan 18, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, lets do it! Actually I was surprised that SPI is not supplying it, since it would have seemed the more natural way to interface with SPI than the current one. Can you point me to the relevant file/code section?

Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ysoldakysoldakysoldak left review comments

@b0ch3nskib0ch3nskib0ch3nski left review comments

@soypatsoypatAwaiting requested review from soypat

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@milkpirate@ysoldak@b0ch3nski@soypat

[8]ページ先頭

©2009-2025 Movatter.jp