- Notifications
You must be signed in to change notification settings - Fork967
Feat/nrf52xxx/spi/improve#4699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
// set frequency | ||
var freq uint32 | ||
switch { | ||
case config.Frequency == 0: // default MCU SPI speed | ||
freq = nrf.SPIM_FREQUENCY_FREQUENCY_M4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't see this as improvement :( Previous code looks cleaner to me: separates concerns of a) ensuring default value and b) handling frequency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Found the separate if-statement superfluous, since we already have a flow control on the frequency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can you two@ysoldak,@b0ch3nski agree on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I find switch statements much easier to read but I think it's just a matter of personal preference. Nevertheless, we already have a switch here and that lonely if statement looks like it has rejoined it's people 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I find switch statements much easier to read but I think it's just a matter of personal preference. Nevertheless, we already have a switch here and that lonely if statement looks like it has rejoined it's people 😃
Yes, felt the same to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Regarding switch, I must confess, I was struggling to understand what's going on at first.
I was expecting every 'case' to produce a unique value (number of unique values = number of cases in switch).
I would propose merge two cases, but then case condition becomes long and look ugly.
So I still prefer deal with default value first, then handle the value, regardless default it is or not.
It may look nice/smart to have only one switch without an extra "if" before it, because we can, but I'd say readability suffers, at least in my case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
machine package breaking changes must be discussed beforehand. And some nits
Uh oh!
There was an error while loading.Please reload this page.
// Read implements [io.Reader]. And reads as many bytes as the given buffer is long | ||
func (spi *SPI) Read(r []byte) (int, error) { | ||
return len(r), spi.Tx(nil, r) | ||
} | ||
// Write implements [io.Writer]. And writes as long as there are bytes in w. | ||
func (spi *SPI) Write(w []byte) (int, error) { | ||
return len(w), spi.Tx(w, nil) | ||
} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Read and Write are not part of the SPI interface. It is easy enough to implement an abstraction if needed that works for all SPI hardwares of all MCUs
funcwriteSPI(w []byte,spiinterface {Tx(w,r []byte)error}) (int,error) {returnlen(w),spi.Tx(w,nil)}
milkpirateJan 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, lets do it! Actually I was surprised that SPI is not supplying it, since it would have seemed the more natural way to interface with SPI than the current one. Can you point me to the relevant file/code section?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
65e67b9
to6163664
Compare
Uh oh!
There was an error while loading.Please reload this page.
As requested per#4660 (review)
What I did
SPI