Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(nrf52xxx/adc|spi): adjustable resolution, improve SPI#4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

milkpirate
Copy link
Contributor

@milkpiratemilkpirate commentedDec 15, 2024•
edited
Loading

What I did

SPI

  • CreateSPIMode type
  • Make SPI implementio.Reader,io.Writer
  • Update formatting to align with other switch-cases
  • Update SPI documentation reference

ADC

  • Change ADC methods to pointer receivers
  • Make ADC resolution adjustable
  • Remove nonsensical calculations (at least to me they seemed like, please correct me if I'm wrong)
  • Update ADC documentation reference

Open questions

  • Will make sense to change the signature ofADC.Get() to return an error? Since it will change the interface and might break things.
  • How to run the added tests?

@milkpiratemilkpirateforce-pushed thefeat/nrf52xxx/adc/make-resolution-changeable branch 5 times, most recently from72d63a4 tof10ed73CompareDecember 16, 2024 22:25
@milkpiratemilkpirate marked this pull request as ready for reviewDecember 16, 2024 22:36
@milkpiratemilkpirateforce-pushed thefeat/nrf52xxx/adc/make-resolution-changeable branch fromf10ed73 toc84ce10CompareDecember 17, 2024 00:16
Copy link
Contributor

@ysoldakysoldak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd prefer this PR to be split into two: separately ADC and SPI changes.

You also need to justify the testify (:D) addition -- we don't have tests in machine package, probably better to make a separate PR for that too.

Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
…6, bit shifting does not make sense, <0 check neitherSigned-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpiratemilkpirateforce-pushed thefeat/nrf52xxx/adc/make-resolution-changeable branch fromc84ce10 tode4ef7aCompareJanuary 14, 2025 20:57
@milkpirate
Copy link
ContributorAuthor

milkpirate commentedJan 14, 2025•
edited
Loading

in favor of other PRs:

ysoldak reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ysoldakysoldakysoldak requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@milkpirate@ysoldak
[8]ページ先頭
©2009-2025 Movatter.jp