Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

net: enable native golang linux networking#4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
leongross wants to merge14 commits intotinygo-org:dev
base:dev
Choose a base branch
Loading
fromleongross:net-linux-nonlinux

Conversation

leongross
Copy link
Contributor

@leongrossleongross commentedOct 4, 2024•
edited
Loading

This is a rework of the plain linux network POC#4460. This PR adds adaptive switching of network packages depending on theGOOS.

The CI fails due to unadjusted build tags for MacOs and WASm.
Successfully tested onlinux/amd64.

noboruma and everyx reacted with heart emoji
@leongrossleongrossforce-pushed thenet-linux-nonlinux branch 7 times, most recently frombbd514e tofdc75d6CompareOctober 8, 2024 09:35
@leongrossleongross marked this pull request as ready for reviewOctober 8, 2024 09:47
Copy link
Member

@aykevlaykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

How did you test this?

To accept this into TinyGo, I'd like to see at least some tests. For example, you can create a new test like testdata/net.go (and add it to main_test.go for Linux only). It doesn't have to be exhaustive, but for example you can start a socket server (net.Listen) in a goroutine and try to connect to it from the same program.

@leongross
Copy link
ContributorAuthor

@aykevl I will add some basic tests. Since I already did some testing (I hope) it should be fairly easy to integrate this here.

@leongrossleongross mentioned this pull requestOct 11, 2024
@leongrossleongrossforce-pushed thenet-linux-nonlinux branch 4 times, most recently from4ec411d toe1f18b2CompareOctober 28, 2024 09:57
@leongrossleongrossforce-pushed thenet-linux-nonlinux branch 3 times, most recently from81fd6ff to52be3d8CompareNovember 4, 2024 16:32
panic("todo: runtime_pollServerInit")
// fmt.Printf("poll_runtime_pollServerInit not implemented, skipping panic\n")
Copy link
Member

@aykevlaykevlNov 8, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If you put in debugging code, please remove it before sending in a PR. It makes the diff bigger and more work to review.
Generally, take a look at the PR diff and see if there's any part of it that is not necessary and can be removed (such as the changes to.gitmodules and the signal changes that are still part of this PR).
(Also, how do you know that you can just remove this panic?)

leongross reacted with thumbs up emoji
@leongrossleongrossforce-pushed thenet-linux-nonlinux branch 8 times, most recently from72cea16 to182dd87CompareNovember 11, 2024 12:04
Signed-off-by: leongross <leon.gross@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com>
if this does not work, do the folliwing steps:1. remove net submodule2. remove symlink in local ~/.cache/tinygo/goroot-<hash>/net3. manual symlink yo local golang /usr/local/bin/src/netSigned-off-by: leongross <leon.gross@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aykevlaykevlaykevl requested changes

@dgryskidgryskidgryski left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@leongross@aykevl@dgryski
[8]ページ先頭
©2009-2025 Movatter.jp