- Notifications
You must be signed in to change notification settings - Fork231
add Digital Motion Processor for MPU6050 - see issue #733#796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:release
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
See the comments. Essentially, this needs a bit more integration into the drivers repo to be mergeable, meaning the PR should modify the existing mpu6050 driver instead of creating a whole new driver from scratch that duplicates functionality with the existing driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If this is an example, it should be in examples/mpu6050.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please don't include files like these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think Python examples belong in the drivers repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You are essentially recreating the MPU6050 driver here. I really don't want to see two drivers for the same hardware. So my suggestion would be to integrate the DMP changes you made into the existing MPU6050 driver, instead of adding a new driver.
Hi Ayke,Yea I figured that much, hence my initial email.Sorry about the .DSstore - i thought I killed it..With regards to the topology I will have to think it through and give it atry. In my repo the code is obviously coupled close to the application andpurpose. The tinygo driver layout is more of a challenge to me and I needto apply some refactoring. I do agree with the example stuff - it was myinitial concern - but the only way to context with the original Youtubeexplanation. Theory is important, you know...I will have a go at it later when I manage to wrap my mind around thestructure and merger and still keep the context intact. Nevertheless, I getthe gist of it.If you have more ideas, I am all ears. I will get back to you.B …On Sat, 4 Oct 2025 at 11:25, Ayke ***@***.***> wrote: ***@***.**** requested changes on this pull request. See the comments. Essentially, this needs a bit more integration into the drivers repo to be mergeable, meaning the PR should modify the existing mpu6050 driver instead of creating a whole new driver from scratch that duplicates functionality with the existing driver. ------------------------------ On mpu6050/digital_motion_processor/main.go <#796 (comment)>: If this is an example, it should be in examples/mpu6050. ------------------------------ On mpu6050/digital_motion_processor/python-animation/.DS_Store <#796 (comment)>: Please don't include files like these. ------------------------------ On mpu6050/digital_motion_processor/python-animation/Animation.py <#796 (comment)>: I don't think Python examples belong in the drivers repo. ------------------------------ On mpu6050/digital_motion_processor/mpu6050/DMP.go <#796 (comment)>: You are essentially recreating the MPU6050 driver here. I really don't want to see two drivers for the same hardware. So my suggestion would be to integrate the DMP changes you made into the existing MPU6050 driver, instead of adding a new driver. — Reply to this email directly, view it on GitHub <#796 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABN6M5S3NZUQQDS6DB5NN5T3V6G6ZAVCNFSM6AAAAACIEPTNASVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMBRG4YDMNRSGE> . You are receiving this because you authored the thread.Message ID: ***@***.***> |
Extend the MPU6050 go drivers with Digital Motion Processing functionality. This version does not have a gimble lock.
See issue 733: Please submit a Pull Request.