- Notifications
You must be signed in to change notification settings - Fork137
Switch benches to usedivan
#281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
CosmicHorrorDev wants to merge9 commits intotiny-http:masterChoose a base branch fromCosmicHorrorDev:divan
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Builds on top of#274 to get CI passing
TODO(cosmic): this PR bumps the MSRV up to 1.80 because the MSRV CI job is currently using
cargo test
instead ofcargo check
. Fix that at some point...Switches from using the unstable
test
feature to using thedivan
crate to run the benchmarks. Thecriterion
crate is another popular alternative, but I preferdivan
because it's a lot lighter in generalI also took the liberty of expanding the
parallel_requests
benchmark to run over a variety of number of requests instead of just 1000Current output
This PR