- Notifications
You must be signed in to change notification settings - Fork137
Use thehttp
crate#277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
CosmicHorrorDev wants to merge12 commits intotiny-http:masterChoose a base branch fromCosmicHorrorDev:http-crate
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
7de4af5
to70b0081
Compare8fb9eca
tocaca7da
Compare42d1274
to65b6621
CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Builds on top of#274
Handles all of the straightfoward changes in building on top of the
http
crate instead of the bespoke internal definitions now thathttp
is reasonably stable. This handles portingVec<tiny_http::Header>
->http::HeaderMap
tiny_http::Header
andtiny_http::HeaderField
tiny_http::StatusCode
->http::StatusCode
tiny_http::Method
->http::Method
tiny_http::HTTPVersion
->http::Version
String
URL paths ->http::Uri
closes#278closes#100
other
&str
parameter really need to have static lifetime inHeaderField::equiv
? #278http::header::HeaderName
has aPartialEq<&'a str>
that's not the'static
lifetime (although fixing the issue directly is also trivial)http::HeaderMap
is a customized hashmap specifically for headers, so I'd imagine the performance is goodFuture work
I might get around to making some of the changes in this PR, but the main missing pieces now are
http
'sRequest
andResponse
types along with their correspondingParts
andBuilder
s. TheRequest
andResponses
have some more significant differences, so potentially just easing conversion between them