Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add#[must_use] toResponse struct#259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
JarredAllen wants to merge1 commit intotiny-http:master
base:master
Choose a base branch
Loading
fromJarredAllen:patch-1

Conversation

JarredAllen
Copy link

(feel free to close if you disagree with me that this is a desirable feature)

I just had a bug-hunting session that resulted in me accidentally writing code:

fn handle_request(request:Request){if <"If-None-Match" header with matchingETag was sent>{Response::empty(304);}    request.respond(Response::new(..)).unwrap();}

when I meant to write the code:

fn handle_request(request:Request){if <"If-None-Match" header with matchingETag was sent>{        request.respond(Response::empty(304)).unwrap();return;}    request.respond(Response::new(..)).unwrap();}

This attribute will prevent that from happening (though it is backwards-incompatible, so this probably should wait for the next major release).

(feel free to close if you disagree with me that this is a desirable feature)I just had a bug-hunting session that resulted in me accidentally writing code:```rustfn handle_request(request: Request) {    if <"If-None-Match" header with matching ETag was sent> {        Response::empty(304);    }    request.respond(Response::new(..)).unwrap();}```when I meant to write the code:```rustfn handle_request(request: Request) {    if <"If-None-Match" header with matching ETag was sent> {        request.respond(Response::empty(304)).unwrap();        return;    }    request.respond(Response::new(..)).unwrap();}```This attribute will prevent that from happening (though it is backwards-incompatible, so this probably should wait for the next major release).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@JarredAllen

[8]ページ先頭

©2009-2025 Movatter.jp