Commit9713f73

committed

Advance deprecation of fwf_empty(skip_empty_rows =)

1 parent18af120 commit9713f73Copy full SHA for 9713f73

File tree

+23

-4

lines changed

+23

-4

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,9 @@`
`12`	`12`	`are now available in the meltr package`
`13`	`13`	`(https://github.com/r-lib/meltr).`
`14`	`14`
	`15`	+* The`skip_empty_rows` argument of`fwf_empty()` now throws an error if used in
	`16`	`+ edition 2. This argument was deprecated in readr 2.0.0 (2021-07-20).`
	`17`	`+`
`15`	`18`	`#readr 2.1.6`
`16`	`19`
`17`	`20`	*`locale(encoding =)` now warns, instead of errors, when the`encoding` cannot

Lines changed: 19 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -134,13 +134,22 @@ read_fwf <- function(`
`134`	`134`	`fwf_empty<-function(`
`135`	`135`	`file,`
`136`	`136`	`skip=0,`
`137`		`-skip_empty_rows=FALSE,`
	`137`	`+skip_empty_rows=deprecated(),`
`138`	`138`	`col_names=NULL,`
`139`	`139`	`comment="",`
`140`	`140`	`n=100L`
`141`	`141`	`) {`
`142`	`142`	`if (edition_first()) {`
`143`		`-ds<- datasource(file,skip=skip,skip_empty_rows=skip_empty_rows)`
	`143`	`+skip_empty_rows<-if (is_present(skip_empty_rows)) {`
	`144`	`+skip_empty_rows`
	`145`	`+ }else {`
	`146`	`+FALSE`
	`147`	`+ }`
	`148`	`+ds<- datasource(`
	`149`	`+file,`
	`150`	`+skip=skip,`
	`151`	`+skip_empty_rows=skip_empty_rows`
	`152`	`+ )`
`144`	`153`
`145`	`154`	`out<- whitespaceColumns(ds,comment=comment,n=n)`
`146`	`155`	`out$end[length(out$end)]<-NA`
`@@ -151,7 +160,14 @@ fwf_empty <- function(`
`151`	`160`	`}`
`152`	`161`
`153`	`162`	`if (!missing(skip_empty_rows)) {`
`154`		`-lifecycle::deprecate_soft("2.0.0","readr::fwf_empty(skip_empty_rows = )")`
	`163`	`+lifecycle::deprecate_stop(`
	`164`	`+when="2.0.0",`
	`165`	`+what="readr::fwf_empty(skip_empty_rows = )",`
	`166`	`+details= c(`
	`167`	`+"i"="This argument is not supported in readr edition 2.",`
	`168`	+"i"="Use `with_edition(1, ...)` or `local_edition(1)` to use the legacy edition 1."
	`169`	`+ )`
	`170`	`+ )`
`155`	`171`	`}`
`156`	`172`
`157`	`173`	`vroom::fwf_empty(`

Lines changed: 1 addition & 1 deletion

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

Comments

(0)