- Notifications
You must be signed in to change notification settings - Fork2.1k
Deprecate theoptional_aes field in Geom/Stat#6400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
thomasp85 commentedDec 4, 2025
I'm slightly unsure why we need this. Yes, it "simplifies" the class definition, but on the other hand it also removes some self-documenting aspects of it. Do you have other reasons for this beside "we can do without"? |
teunbrand commentedDec 4, 2025
The main reason I'd say is that it is a cause of confusion when learning how to build ggplot2 extensions because it isn't really clear what should go into |
This PR aims tofix#6393.
It takes the 'violent' path of deprecating the field.
We can also choose to delay deprecating the field.