Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Deprecate theoptional_aes field in Geom/Stat#6400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
teunbrand wants to merge5 commits intotidyverse:main
base:main
Choose a base branch
Loading
fromteunbrand:deprecate_optional_aes

Conversation

@teunbrand
Copy link
Collaborator

This PR aims tofix#6393.

It takes the 'violent' path of deprecating the field.
We can also choose to delay deprecating the field.

@thomasp85
Copy link
Member

I'm slightly unsure why we need this. Yes, it "simplifies" the class definition, but on the other hand it also removes some self-documenting aspects of it.

Do you have other reasons for this beside "we can do without"?

@teunbrand
Copy link
CollaboratorAuthor

The main reason I'd say is that it is a cause of confusion when learning how to build ggplot2 extensions because it isn't really clear what should go intooptional_aes. It is better now that#6426 describes the field, but it remains somewhat redundant and befuddles a clear path for how to implement optional aesthetics.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Discourage use ofoptional_aes field

2 participants

@teunbrand@thomasp85

[8]ページ先頭

©2009-2025 Movatter.jp