- Notifications
You must be signed in to change notification settings - Fork2.1k
WIP: Missing values in colourbars#6023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
teunbrand wants to merge7 commits intotidyverse:mainChoose a base branch fromteunbrand:bar_missing
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR aims tofix#4567.
Briefly,
guide_colourbar()andguide_coloursteps()use theGuideLegendclass to render a key for missing values.Note that continuous scales never automatically include
NAin breaks (AFAIK), which means that you'd have to add these manually.It'd also will prevent some complaints that suddenly the colourbars show
NAs by default (as they don't).In the plot below you can see a demo of what these look like. Note that putting
NAas the first break will put it on top of the bar, whereas using it as any other break will put it on the bottom. However, maybe we should reverse this logic to follow the order of the other breaks?Created on 2024-08-02 withreprex v2.1.1
I'm not 100% happy with the code as-is; it feels a little bit messy. Most of the logic is captured in
Guide$assemble_drawing()but it doesn't quite feel like the correct place. In addition, getting binned breaks to includeNAis messier than I'd like. Lastly, maybe we should also do this forguide_bins(), but I feel like it has less priority due to it being a more niche guide (and I'd rather not mess with binned breaks again).