- Notifications
You must be signed in to change notification settings - Fork2.1k
Addstrip.spacing
theme element#5958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I am pretty sure this might have consequences for patchwork. Can I get you to look into this before we move forward? |
teunbrand commentedAug 20, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hmm you're right that this doesn't work with patchwork. The PR essentially uses the same gtable cells as the |
Uh oh!
There was an error while loading.Please reload this page.
This PR aims tofix#5935.
Briefly, a new theme element
strip.spacing
is used to set the distance from the panel to the strip unconditionally.Previously, we could only use
strip.switch.pad.{grid/wrap}
to set this distance, but only if there was an axis in between the panel and the strip. In case the conditions for thestrip.switch.pad.{grid/wrap}
are met, thenstrip.spacing
is additive to that spacing. The default spacing isrel(0)
inheriting from the roottheme(spacing)
argument, so it doesn't add space by default.However, it does add a gtable cell even when there is 0-spacing, which helps towards#5628 as the gtable shape no longer depends on the relative placement of axes and strips (the cell is added regardless).
To give a few examples. We weren't able to do this before:
Or this:
Created on 2024-06-27 withreprex v2.1.0