Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update facet_wrap (adjsut the strip position for each panel when strip.placement is "outside")#5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
junjunlab wants to merge1 commit intotidyverse:main
base:main
Choose a base branch
Loading
fromjunjunlab:main

Conversation

@junjunlab
Copy link

  1. Making sure thestrip.switch.pad.wrap works whenstrip.placement=outside andstrip.position="top".
  2. Giving same gap between the strip and panel whenstrip.position is"left"/"right" or whennrow>2.

@teunbrand
Copy link
Collaborator

Hi, thanks for putting together a PR!
If I read the code correctly, this change applies the padding regardless of whether an axis is placed between the panel and the strip, right?
If so, that breaks with what is documented for thestrip.switch.pad.* arguments.
Would you mind opening an issue first describing the problem you are interested in solving?
This way, we may be able to discuss and better guide a contribution.

@junjunlab
Copy link
Author

Sure, I will open an issue now. Thanks for your replying.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@junjunlab@teunbrand
[8]ページ先頭
©2009-2025 Movatter.jp