Fix path encoding#978

Merged

tiangolo merged 4 commits intofastapi:masterfrom

patrickmckenna:fix-path-encoding

Feb 16, 2020

Merged

Fix path encoding#978
tiangolo merged 4 commits intofastapi:masterfrom
patrickmckenna:fix-path-encoding

Conversation

Copy link

Contributor

patrickmckenna commentedFeb 13, 2020•
edited by tiangolo
Loading

This PR adds a case tojsonable_encoder so thatpathlib.PurePath objects are serializable. Related to#563.

I know there was some discussion in that thread about how to handle the OS-dependentstr representations ofpathlib.Path objects. Perhaps I'm misunderstanding something, but shouldn't users who need OS-agnostic treatment of paths be usingpathlib.Pure*Path types to getstr representations in their native form, no matter where their code is running?

/cc@devtud

patrickmckenna added4 commits

February 12, 2020 16:44

add failing test

f3a3f5d

test all path flavors

cf26ab7

serialize all paths w/ str()

ea128da

pledge fealty to the linting gods

379921a

Copy link

codecovbot commentedFeb 13, 2020•
edited
Loading

Codecov Report

Merging#978 intomaster willnot change coverage.
The diff coverage is100%.

@@          Coverage Diff          @@##           master   #978   +/-   ##=====================================  Coverage     100%   100%           =====================================  Files         294    294             Lines        7717   7732   +15     =====================================+ Hits         7717   7732   +15

Impacted Files	Coverage Δ
fastapi/encoders.py	`100% <100%> (ø)`	⬆️
tests/test_jsonable_encoder.py	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update66954c7...379921a. Read thecomment docs.