OpenAPI schema generation: Don't convert all enums into str#906

Merged

tiangolo merged 2 commits intofastapi:masterfrom

songzhi:patch-1

Feb 4, 2020

Merged

OpenAPI schema generation: Don't convert all enums into str#906
tiangolo merged 2 commits intofastapi:masterfrom
songzhi:patch-1

Conversation

Copy link

Contributor

songzhi commentedJan 22, 2020

Before doing this,the type of values inenum could be at odds withtype field.

Don't convert all enums into str

2de3711

Before doing this,the type of  values in `enum` could be at odds with `type` field.

Copy link

codecovbot commentedJan 22, 2020•
edited
Loading

Codecov Report

Merging#906 intomaster willdecrease coverage by0.07%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master     #906      +/-   ##==========================================- Coverage     100%   99.92%   -0.08%==========================================  Files         293      293                Lines        7692     7701       +9     ==========================================+ Hits         7692     7695       +3- Misses          0        6       +6

Impacted Files	Coverage Δ
fastapi/openapi/models.py	`100% <100%> (ø)`	⬆️
fastapi/concurrency.py	`77.77% <0%> (-22.23%)`	⬇️
tests/test_filter_pydantic_sub_model.py	`100% <0%> (ø)`	⬆️
fastapi/utils.py	`100% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update55afb70...47e6e0a. Read thecomment docs.