Have you confirmed that this doesn't change the validation logic? Probably worth making sure validators still work on endpoints with a response model (maybe this is already tested in the existing tests).

Pydantic has some metaprogramming magic that could mean the validators don't get set up properly if they aren't present during class initialization; I'm not sure.

Codecov Report

Merging#637 intomaster willnot change coverage.
The diff coverage is100%.

@@          Coverage Diff          @@##           master   #637   +/-   ##=====================================  Coverage     100%   100%           =====================================  Files         269    269             Lines        6823   6824    +1     =====================================+ Hits         6823   6824    +1

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update65536cb...25540ed. Read thecomment docs.

Have you confirmed that this doesn't change the validation logic? Probably worth making sure validators still work on endpoints with a response model (maybe this is already tested in the existing tests).

Yes, all of the endpoints in my projects haveresponse_model parameters set, and all are functioning as expected. That said, I assume that package tests would find any bugs introduced in this regard? 🤔

Looks good to me!

Great! Thank you@jaddison! 🚀 🍰

And thanks@dmontagu for the PR review, that's highly appreciated 💪 🌮