Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Comments
✏️ Update highlighted line indocs/en/docs/tutorial/bigger-applications.md#5490
✏️ Update highlighted line indocs/en/docs/tutorial/bigger-applications.md#5490alejsdev merged 4 commits intofastapi:masterfrom
docs/en/docs/tutorial/bigger-applications.md#5490Conversation
📝 Docs preview for commitf598e52 at:https://63473fe4aeb3b90fd9daa586--fastapi.netlify.app |
codecovbot commentedOct 12, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #5490 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 540 540 Lines 13969 13934 -35 =========================================- Hits 13969 13934 -35 ☔ View full report in Codecov by Sentry. |
📝 Docs preview for commit3dec641 at:https://639cdfc9e97dd30578989db8--fastapi.netlify.app |
Ryandaydev left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@papb If I am reading the tutorial correctly, the existing doco incorrectly highlights row 4.
I think instead of this change (which highlights lines 4 & 5), I think it should be changed to highlight row 5.
papb commentedDec 22, 2022
@Ryandaydev Thank you, you're right. After re-reading I decided to also change another block to highlight one extra line, can you take a look? |
📝 Docs preview for commite3b590b at:https://63a3ee1a51a71e488d9d9ea1--fastapi.netlify.app |
iudeen left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good. Nice catch!
Ryandaydev left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Requested changes have been applied.
papb commentedMar 13, 2023
How can I help this PR move forward? |
docs/en/docs/tutorial/bigger-applications.mdalejsdev commentedJan 11, 2024
Good catch. Thanks@papb 🙂 And thanks for the review@iudeen and@Ryandaydev ✌️ |
No description provided.