Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

⬆ Upgrade Starlette to0.21.0, including the new [TestClient based on HTTPX](https://github.com/encode/starlette/releases/tag/0.21.0)#5471

Merged
tiangolo merged 2 commits intofastapi:masterfrom
pawelrubin:update-starlette
Nov 13, 2022
Merged

⬆ Upgrade Starlette to0.21.0, including the new [TestClient based on HTTPX](https://github.com/encode/starlette/releases/tag/0.21.0)#5471
tiangolo merged 2 commits intofastapi:masterfrom
pawelrubin:update-starlette

Conversation

@pawelrubin
Copy link
Contributor

@pawelrubinpawelrubin commentedOct 7, 2022•
edited
Loading

This PR updates the starlette version to the latest0.21.0 release.

The latest starlette release comes with some breaking changes to the TestClient as mentioned in the release notes:

This release replaces the underlying HTTP client used on the TestClient (requests ➡️ httpx), and as those clientsdiffer a bit on their API, your test suite will likely break. To make the migration smoother, you can use thebump-testclient tool.

I've used thebump-testclient tool and fixed other issues myself.

gertcuykens, JarroVGIT, svercl, woile, fxrcode, vergeev, mayasse, georborodin, lossyrob, iandronis, and 7 more reacted with thumbs up emojiscarchik, thomasleveil, vergeev, and dekoza reacted with heart emojithomasleveil, vergeev, pelzhaus, and philqc reacted with eyes emoji
@github-actions
Copy link
Contributor

📝 Docs preview for commitb5a22a2 at:https://633ff3b942952d32ba54f470--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit3f447ff at:https://633ff566f692d72eb442e9b1--fastapi.netlify.app

@pawelrubinpawelrubin marked this pull request as ready for reviewOctober 7, 2022 09:51
@github-actions
Copy link
Contributor

📝 Docs preview for commita682e85 at:https://633ff7ce2ec6962f37f8e7db--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit431f420 at:https://633ff94a4c600e2842d094a0--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commitb4f7e87 at:https://633ffbea31944f35e7bcf770--fastapi.netlify.app

@pawelrubinpawelrubinforce-pushed theupdate-starlette branch 2 times, most recently from07d5cda to359684eCompareOctober 7, 2022 10:18
@codecov
Copy link

codecovbot commentedOct 7, 2022•
edited
Loading

Codecov Report

Base:100.00% // Head:100.00% // No change to project coverage 👍

Coverage data is based on head(982e7ca) compared to base(cf73051).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head982e7ca differs from pull request most recent headce5b5f7. Consider uploading reports for the commitce5b5f7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@##            master     #5471   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          540       540             Lines        13969     13958   -11     =========================================- Hits         13969     13958   -11
Impacted FilesCoverage Δ
fastapi/security/api_key.py100.00% <100.00%> (ø)
fastapi/security/http.py100.00% <100.00%> (ø)
fastapi/security/oauth2.py100.00% <100.00%> (ø)
fastapi/security/open_id_connect_url.py100.00% <100.00%> (ø)
fastapi/security/utils.py100.00% <100.00%> (ø)
tests/test_enforce_once_required_parameter.py100.00% <100.00%> (ø)
tests/test_extra_routes.py100.00% <100.00%> (ø)
tests/test_get_request_body.py100.00% <100.00%> (ø)
tests/test_param_include_in_schema.py100.00% <100.00%> (ø)
tests/test_security_api_key_cookie.py100.00% <100.00%> (ø)
... and17 more

Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment?Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit359684e at:https://633ffde84e2f313c833a0d36--fastapi.netlify.app

Copy link
Contributor

@yezz123yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks compatible with the changes in Starlette ✨ 🚀

pawelrubin reacted with thumbs up emoji
@github-actions
Copy link
Contributor

📝 Docs preview for commit7607ea7 at:https://63401cb41ade06008e6c0692--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit01c4960 at:https://63401dc0f8e580024f94ca9d--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commitcf84079 at:https://634020f91ade0602a76c06ab--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit5d8a327 at:https://634022871fbcbd077dc05162--fastapi.netlify.app

Copy link
Member

@KludexKludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@tiangolo You have the release notes, but remember thatWebSocketException is included in this version. I guess you'd like to document that. 👀

pawelrubin reacted with thumbs up emoji
@github-actions
Copy link
Contributor

📝 Docs preview for commitb0ec5cf at:https://634053cd241aac22df3cf2c9--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commite0a4aa9 at:https://6346755ac01af03a63982f2c--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit982e7ca at:https://63526d604b095122142240ab--fastapi.netlify.app

@pawelrubin
Copy link
ContributorAuthor

Hi@tiangolo, could you have a look at this PR? 🙏🏻

acjh, rgrignon1, ccesareo-psyop, ramiswailem, HarrySky, vergeev, philqc, and pelzhaus reacted with rocket emoji

@pawelrubinpawelrubinforce-pushed theupdate-starlette branch 2 times, most recently from54ca46f to68fad0bCompareNovember 1, 2022 08:26
@github-actions
Copy link
Contributor

📝 Docs preview for commit68fad0b at:https://6360d932a824d00074759e57--fastapi.netlify.app

- Adapt tests suite after breaking changes to the starlette's TestClient- Fix issues found by mypy caused by more precise type annotations in starlette
@github-actions
Copy link
Contributor

📝 Docs preview for commit175022a at:https://6364ac09c42e4e5066030b85--fastapi.netlify.app

@thomasleveil
Copy link
Contributor

SinceThis release replaces the underlying HTTP client used on the TestClient (requests arrow_right httpx), should this be considered introducing breaking changes ?

@pawelrubin
Copy link
ContributorAuthor

pawelrubin commentedNov 4, 2022•
edited
Loading

@thomasleveil Yes, it does introduce a breaking change, but only to theTestClient. Assuming that theTestClient is not used in any application code, this change will break only the test suites, which shouldn't be a big deal.

Whether such a breaking change should result in a new major or minor version is up to@tiangolo I guess.

elpablete reacted with thumbs up emoji

@Kludex
Copy link
Member

It's going to be a minor.

pawelrubin, vergeev, hidaris, and tiangolo reacted with thumbs up emoji

@tiangolotiangolo changed the titleUpdate starlette to 0.21.0.⬆ Upgrade Starlette to0.21.0, including the new [TestClient based on HTTPX](https://github.com/encode/starlette/releases/tag/0.21.0)Nov 13, 2022
@tiangolo
Copy link
Member

Amazing, great job@pawelrubin, thanks! 🍰 ☕

And thanks for the help and comments everyone! 🤓

I just fixed a couple of tests and it's now ready. It will be available in the next version0.87.0, released in the next hours. 🎉

Kludex reacted with thumbs up emojithomasleveil and vergeev reacted with hooray emojipawelrubin, musicinmybrain, and anydayeol reacted with heart emojipawelrubin and iudeen reacted with rocket emoji

@tiangolotiangolo merged commitfdbd48b intofastapi:masterNov 13, 2022
diegoquintanav added a commit to diegoquintanav/datadis that referenced this pull requestJan 9, 2023
fix/upgrade dependenciesupgrades python version to 3.10.5upgrades dependencies to their latest versionsthis is needed because of pinned httpx version is outdated and TestClient breaks starlette and FastAPIreferencesKludex/starlette#1376fastapi/fastapi#5471fastapi/fastapi#5749
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@KludexKludexKludex left review comments

+4 more reviewers

@thomasleveilthomasleveilthomasleveil left review comments

@gertcuykensgertcuykensgertcuykens left review comments

@musicinmybrainmusicinmybrainmusicinmybrain left review comments

@yezz123yezz123yezz123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pawelrubin@thomasleveil@Kludex@tiangolo@gertcuykens@musicinmybrain@yezz123

Comments

[8]ページ先頭
©2009-2026 Movatter.jp