📝 Docs preview for commit1dbbab6 at:https://633efa56cd26a21a02038871--fastapi.netlify.app

Codecov Report

Base:100.00% // Head:100.00% // No change to project coverage 👍

Coverage data is based on head(adcdf4d) compared to base(e92a864).
Patch coverage: 100.00% of modified lines in pull request are covered.

@@            Coverage Diff            @@##            master     #5465   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          540       540             Lines        13946     13969   +23     =========================================+ Hits         13946     13969   +23

☔ View full report at Codecov.
📢 Do you have feedback about the report comment?Let us know in this issue.

Looks like failures are unrelated to this change:#5467

📝 Docs preview for commitc9d151f at:https://6345ec6f26f61e4cf776afde--fastapi.netlify.app

Failures resolved,@tiangolo I think this is ready for review :)

📝 Docs preview for commit2841a7a at:https://635395c8c62971556f3d83d9--fastapi.netlify.app

Amazing, thank you@adriangb! 🙇

Do you think you could add a test or two for this?

I think this might difficult to test without touching the internals of something. It does run for every test, so we know that it doesn’t crash at least. I’ll think a bit about how to test this.

📝 Docs preview for commit8a28c02 at:https://636003d3f67bae05d1213030--fastapi.netlify.app

📝 Docs preview for commit1887507 at:https://636014d7a81e9f143d87f066--fastapi.netlify.app

So it seems like even Starlette is not testing thatUploadFile.close gets called. I don't see any way to test this other than doing some monkey patching of stuff like that.@tiangolo would you accept this without a test or is that a no-go?

📝 Docs preview for commita1fa01b at:https://636033086842892df4729409--fastapi.netlify.app

📝 Docs preview for commitadcdf4d at:https://6363ae2be9a9080232218a2a--fastapi.netlify.app

I found a way to test it! 🎉 I added the commit on top.

Thanks for the contribution! 🚀

That was genius!

Haha thank you! 😊🙈🤓