Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Comments
📝 Remove unneeded Django/Flask references from async topic intro#5280
Merged
tiangolo merged 2 commits intofastapi:masterfromAug 18, 2022
carltongibson:adjust-docs
Merged
📝 Remove unneeded Django/Flask references from async topic intro#5280tiangolo merged 2 commits intofastapi:masterfromcarltongibson:adjust-docs
tiangolo merged 2 commits intofastapi:masterfrom
carltongibson:adjust-docs
Conversation
codecovbot commentedAug 18, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #5280 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 532 532 Lines 13684 13684 ========================================= Hits 13684 13684 Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here. |
Contributor
📝 Docs preview for commit83d8a63 at:https://62fddf7630df896b7aad8a37--fastapi.netlify.app |
Member
tiangolo commentedAug 18, 2022
Thanks for the contribution@carltongibson! 🚀 🍰 |
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull requestAug 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading this lovely introduction to async yesterday, I was struck by the Flask and Django references, which seemed unneeded, and increasingly not really accurate.
I thought the document would read better simply dropping them.
So I thought I'd suggest that.
Keep up the good work! 🎁